Skip to content

fix: use tmpfs for Docker execution - #200

Open
erickcestari wants to merge 1 commit into
lnfuzz:masterfrom
erickcestari:docker-run-tmpfs
Open

fix: use tmpfs for Docker execution#200
erickcestari wants to merge 1 commit into
lnfuzz:masterfrom
erickcestari:docker-run-tmpfs

Conversation

@erickcestari

Copy link
Copy Markdown
Contributor

Docker containers perform disk I/O by default, unlike the NYX VM, which runs from initramfs and is significantly faster. Use a tmpfs for /tmp in local execution, coverage reporting, and crash symbolization to better match the NYX environment.

Also document the tmpfs option and add the ir scenario to the script usage information.

Docker containers perform disk I/O by default, unlike the NYX VM,
which runs from initramfs and is significantly faster. Use a tmpfs
for /tmp in local execution, coverage reporting, and crash
symbolization to better match the NYX environment.

Also document the tmpfs option and add the ir scenario to the
script usage information.

@ekzyis ekzyis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 171064c just one question, but can be ignored

case "$TARGET" in
lnd)
docker run --rm "${DOCKER_USER[@]}" \
--tmpfs /tmp:rw,exec,size=1g \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious: could there be a reason to not want to use --tmpfs here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see reasons to have, but I could be wrong. On my tests it was able to run 2 times faster than without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants