[flang] added write-after-endfile testcase#396
Conversation
|
Is this test being added to the correct subdirectory of the cray tests? |
|
I will review this. I'm contacting the author about the related PR first. |
|
Hi @blazie2004. I have a couple of general recommendations:
Thank you. |
|
@blazie2004, Please see LLVM's developer guide on pull requests - in particular, the sections on updating and rebasing PR's. |
kwyatt-ext
left a comment
There was a problem hiding this comment.
After you remove the extra file, this should be ready to go, with the following exceptions:
- It still will NOT pass with the draft PR code changes.
- It can not be merged until the associated fix has been merged.
| @@ -0,0 +1,52 @@ | |||
| program test_io_err | |||
There was a problem hiding this comment.
You need to delete write-after-endfile.f90 from your commit.
| k after CLOSE: 55 | ||
| iostat after read: 0 k: 65 | ||
| iostat after write: 0 k: 65 | ||
| FAIL No newline at end of file |
There was a problem hiding this comment.
Eugene is right. This expected output is not correct. If your test is successful in branching to the error label for the last 2 cases, then your "k" value should be "66" for both and the final should be PASS.
This test verifies that Fortran I/O statements correctly handle error conditions when ERR= and IOSTAT= specifiers are present. Per Fortran standard 12.11.2, when an error occurs during I/O and either ERR= or IOSTAT= is specified.
PR: 191633