fix(ci): install pnpm in the release workflow - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent — releases are currently blocked until this lands.
What happened
PR #28 unskipped the CLI integration tests, which shell out to whichever package manager the fixture declares.
tests/fixtures/sample-projectships apnpm-lock.yaml, andubuntu-latestdoes not provide pnpm. Apnpm/action-setupstep was added toci.yml, butauto-release.ymlalso runs the full suite in itsVerifystep and was missed. The release run after #28 merged failed with 12JSON.parse ... Unexpected EOFerrors — empty stdout because the CLI could not find pnpm.Why no damage was done
This is the failure mode the restructure in #18 was built for.
Verifyfailed,Commit and push version bumpwas skipped, and the build and release jobs never ran. No version bump reached main and no tag was pushed — the latest tag is still v0.5.1 and main is untouched. Under the old ordering the tag would already have been pushed before the build ran, leaving an orphan tag and a 404 for the Homebrew tap.The fix
Mirror the pnpm setup step from
ci.ymlinto theversionjob ofauto-release.yml, pinned to pnpm 11.9.0. Only that job runs tests — the build and release jobs do not — so one step is sufficient.Verification
actionlintclean on both workflows; confirmed by grep thatversionis the only job invokingjust test.Test plan
actionlintpasses onauto-release.ymlVerifystep succeeds with pnpm available