Skip to content

fix(ci): install pnpm in the release workflow - #29

Merged
llbbl merged 1 commit into
mainfrom
fix/release-pnpm
Aug 23, 2026
Merged

fix(ci): install pnpm in the release workflow#29
llbbl merged 1 commit into
mainfrom
fix/release-pnpm

Conversation

@llbbl

@llbbl llbbl commented Aug 23, 2026

Copy link
Copy Markdown
Owner

Urgent — releases are currently blocked until this lands.

What happened

PR #28 unskipped the CLI integration tests, which shell out to whichever package manager the fixture declares. tests/fixtures/sample-project ships a pnpm-lock.yaml, and ubuntu-latest does not provide pnpm. A pnpm/action-setup step was added to ci.yml, but auto-release.yml also runs the full suite in its Verify step and was missed. The release run after #28 merged failed with 12 JSON.parse ... Unexpected EOF errors — empty stdout because the CLI could not find pnpm.

Why no damage was done

This is the failure mode the restructure in #18 was built for. Verify failed, Commit and push version bump was skipped, and the build and release jobs never ran. No version bump reached main and no tag was pushed — the latest tag is still v0.5.1 and main is untouched. Under the old ordering the tag would already have been pushed before the build ran, leaving an orphan tag and a 404 for the Homebrew tap.

The fix

Mirror the pnpm setup step from ci.yml into the version job of auto-release.yml, pinned to pnpm 11.9.0. Only that job runs tests — the build and release jobs do not — so one step is sufficient.

Verification

actionlint clean on both workflows; confirmed by grep that version is the only job invoking just test.

Test plan

  • actionlint passes on auto-release.yml
  • Next release run's Verify step succeeds with pnpm available

@llbbl
llbbl merged commit 193537d into main Aug 23, 2026
3 checks passed
@llbbl
llbbl deleted the fix/release-pnpm branch August 23, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant