fix(search): prevent stale dialog request state - #90
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 83.62% 89.33% +5.70%
==========================================
Files 12 12
Lines 287 300 +13
Branches 72 71 -1
==========================================
+ Hits 240 268 +28
+ Misses 28 16 -12
+ Partials 19 16 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Summary
AbortControllerownership guards so only the current request can update loading, errors, and results.Validation
pnpm formatpnpm lintpnpm exec tsc --noEmitpnpm test --run(162 tests)pnpm test:coverage --run(overall line coverage 94.48%;Search.tsxline coverage 95.12%)pnpm db:init:localpnpm index:local(3/3 documents)env TURSO_DB_URL=file:local.db TURSO_AUTH_TOKEN=local pnpm build