ci: validate the on-chain overlay too - #4
Merged
Conversation
It is the compose file nobody runs before merging, since it needs a wallet, an RPC and a keystore, and the one most likely to break: ten interpolated variables and a second service. Interpolating .env.example also proves that file still lists every variable the overlay reads. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lint.ymlparsescompose.ymland stops there, socompose.onchain.ymlis never checked by anything.That is the file that most needs it. The offchain path is exercised constantly; the on-chain one needs a wallet, an RPC endpoint and a keystore, so realistically nobody runs it before merging. It is also the more fragile of the two: ten interpolated variables and a second service.
Compose interpolates
${VAR}as text before parsing the result as YAML, so an unset variable does not error, it becomes an empty string and can silently produce something malformed:Interpolating
.env.examplefixes that, and buys a second check for free: if someone adds a${VAR}to the overlay and forgets to document it, CI goes red. Without that the failure lands on a user who copied.env.exampleto.env, filled it in, and still could not start the stack.--env-fileonly feeds interpolation; it puts nothing into any container, and.env.exampleholds placeholders, so no secret is involved.Verified on top of
main: both the existing check and the new one pass, so this adds coverage without papering over an existing break.Same change is open for template-livepeer-runner#3 and runner-app-examples#85, which have the same gap.