Skip to content

Port data streams over to rust livekit-ffi version #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1egoman wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Port data streams over to rust livekit-ffi version #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fd370b3
feat: port data streams to the livekit-ffi rust implementation
1egoman Jul 28, 2026
da90a5b
fix: clean up e2e tests implementation
1egoman Jul 31, 2026
d21086f
fix: ensure that data streams readers are never orphaned when there's…
1egoman Jul 31, 2026
59104b7
fix: backport abandoned data stream writer drop from node-sdks a6f8a35
1egoman Jul 31, 2026
68616e3
fix: address data stream deadlock case when reading a data stream whi…
1egoman Jul 31, 2026
5c6ff63
fix: address backwards compatibility
1egoman Jul 31, 2026
dfc8620
feat: add e2e cases for newly exposed deadlock read case from 68616e3
1egoman Jul 31, 2026
d282840
feat: add closed reader is empty stream test
1egoman Aug 3, 2026
c9b01cb
fix: make test_receiver_rejects_oversized_payload more robust
1egoman Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions livekit-rtc/livekit/rtc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
from .room import (
ConnectError,
DataPacket,
DataStreamOptions,
Room,
RoomOptions,
RtcConfiguration,
Expand Down Expand Up @@ -123,6 +124,7 @@
TextStreamWriter,
ByteStreamWriter,
ByteStreamReader,
StreamError,
)
from .data_track import (
LocalDataTrack,
Expand Down Expand Up @@ -172,6 +174,7 @@
"ConnectError",
"Room",
"RoomOptions",
"DataStreamOptions",
"RtcConfiguration",
"SimulateScenarioKind",
"SipDTMF",
Expand Down Expand Up @@ -217,6 +220,7 @@
"TextStreamWriter",
"ByteStreamReader",
"ByteStreamWriter",
"StreamError",
"AudioProcessingModule",
"PlatformAudio",
"PlatformAudioSource",
Expand Down
9 changes: 9 additions & 0 deletions livekit-rtc/livekit/rtc/_ffi_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ def __del__(self) -> None:
def disposed(self) -> bool:
return self._disposed

def mark_consumed(self) -> None:
"""Marks the handle as already released on the native side.

Some requests take ownership of their handle (``take_handle``) rather
than borrowing it. After issuing one, the handle must not be dropped
again, so this suppresses the drop that dispose/GC would otherwise do.
"""
self._disposed = True

def dispose(self) -> None:
if self.handle != INVALID_HANDLE and not self._disposed:
self._disposed = True
Expand Down
Loading
Loading