Skip to content

egressobs: report audio_only for v2 MediaSource without video #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milos-lk merged 1 commit into from
Oct 9, 2026
Merged

egressobs: report audio_only for v2 MediaSource without video #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/egressobs-media-audio-only.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"github.com/livekit/protocol": patch
"@livekit/protocol": patch
---

`egressobs.GetAudioOnly` reports `true` for v2 egress and replay requests with a `MediaSource` that has no video selector
3 changes: 2 additions & 1 deletion observability/egressobs/egress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,5 +201,6 @@ func GetAudioOnly(info *livekit.EgressInfo) bool {
}

func getAudioOnlyV2(r egress.EgressRequest) bool {
return r.GetTemplate().GetAudioOnly() || r.GetWeb().GetAudioOnly()
return r.GetTemplate().GetAudioOnly() || r.GetWeb().GetAudioOnly() ||
(r.GetMedia() != nil && r.GetMedia().GetVideo() == nil)
}
74 changes: 72 additions & 2 deletions observability/egressobs/egress_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,67 @@ func TestGetAudioOnly(t *testing.T) {
audioOnly: true,
},
{
name: "v2 Media returns false",
name: "v2 Media audio routes only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Media{
Media: &livekit.MediaSource{},
Media: &livekit.MediaSource{
Audio: &livekit.AudioConfig{
Routes: []*livekit.AudioRoute{{
Match: &livekit.AudioRoute_ParticipantIdentity{ParticipantIdentity: "caller"},
Channel: livekit.AudioChannel_AUDIO_CHANNEL_LEFT,
}},
},
},
},
},
},
},
audioOnly: true,
},
{
name: "v2 Media capture all audio",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Media{
Media: &livekit.MediaSource{
Audio: &livekit.AudioConfig{CaptureAll: true},
},
},
},
},
},
audioOnly: true,
},
{
name: "v2 Media video track",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Media{
Media: &livekit.MediaSource{
Video: &livekit.MediaSource_VideoTrackId{VideoTrackId: "TR_video"},
Audio: &livekit.AudioConfig{CaptureAll: true},
},
},
},
},
},
audioOnly: false,
},
{
name: "v2 Media participant video",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Egress{
Egress: &livekit.StartEgressRequest{
Source: &livekit.StartEgressRequest_Media{
Media: &livekit.MediaSource{
Video: &livekit.MediaSource_ParticipantVideo{
ParticipantVideo: &livekit.ParticipantVideo{Identity: "speaker"},
},
},
},
},
},
Expand All @@ -267,6 +322,21 @@ func TestGetAudioOnly(t *testing.T) {
},
audioOnly: true,
},
{
name: "Replay Media audio only",
info: &livekit.EgressInfo{
Request: &livekit.EgressInfo_Replay{
Replay: &livekit.ExportReplayRequest{
Source: &livekit.ExportReplayRequest_Media{
Media: &livekit.MediaSource{
Audio: &livekit.AudioConfig{CaptureAll: true},
},
},
},
},
},
audioOnly: true,
},
{
name: "Track request returns false",
info: &livekit.EgressInfo{
Expand Down
Loading