Repository navigation
fix(sip): match allowed_addresses against the source address only - #1847
Open
cosmin-staicu wants to merge 1 commit into
Open
cosmin-staicu wants to merge 1 commit into
cosmin-staicu wants to merge 1 commit into
Conversation
matchAddrMasks compared an inbound trunk's allowed_addresses with the call's source address and also accepted a mask equal to the From host. Only the source address is compared now. A hostname entry no longer matches, and a list made only of hostnames admits no call. The source address is unmapped first, so an IPv4 peer behind a dual-stack listener (::ffff:a.b.c.d) matches an IPv4 mask. Signed-off-by: Cosmin Staicu <cosmin.staicu@uipath.com>
cosmin-staicu
force-pushed
the
fix/sip-allowed-addresses-source-only
branch
from
October 9, 2026 05:08
0286dcc to
c8b8377
Compare
🦋 Changeset detectedLatest commit: c8b8377 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matchAddrMaskscompares an inbound trunk'sallowed_addresseswith the call's source address, and also accepts a mask equal to the From host. Only the source address is now compared.This changes behaviour for hostname entries: they no longer match, and a list made only of hostnames admits no call.
The source address is also unmapped before the comparison, so an IPv4 peer behind a dual-stack listener (
::ffff:a.b.c.d) matches an IPv4 mask.