Skip to content

fix nil != empty audio config#1597

Merged
frostbyte73 merged 4 commits into
mainfrom
egress-v2-final
Jun 2, 2026
Merged

fix nil != empty audio config#1597
frostbyte73 merged 4 commits into
mainfrom
egress-v2-final

Conversation

@frostbyte73
Copy link
Copy Markdown
Member

No description provided.

@frostbyte73 frostbyte73 requested a review from a team June 2, 2026 05:57
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

⚠️ No Changeset found

Latest commit: 46cda9e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread protobufs/livekit_egress.proto Outdated
// If empty, all audio captured in both channels.
// If non-empty, only matching audio is captured and routed. Unmatched is excluded.
repeated AudioRoute routes = 1;
bool capture_all = 1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does capture_all take precedence? Would be good to have a line of comment on precedence here.

@frostbyte73 frostbyte73 merged commit 6fa7009 into main Jun 2, 2026
5 checks passed
@frostbyte73 frostbyte73 deleted the egress-v2-final branch June 2, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants