Repository navigation
Conversation
Add verwalter.toml and the four verwalter workflows (release PR, release, pre-release, changeset check). Remove the changesets/action job from CI, .changeset/config.json, the ci:publish script and the changesets devDependencies. Pending .changeset/*.md files carry over. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| on: | ||
| pull_request: | ||
| types: [closed] | ||
| branches: [main] |
There was a problem hiding this comment.
🔴 Non-main pre-releases never publish
When pre-release targets another branch, merging its rc PR never triggers Release. The workflow only listens for PRs targeting main, so the rc version remains untagged and unpublished.
Learn more
A pre-release request opens an rc pull request against its selected target branch. pre-release passes the branch name to verwalter, which uses it as the PR base. Release only runs after a PR closes against main. For any other target, the merge creates the rc version in that branch but never tags it or publishes it.
Example: Run Pre-release PR on release-candidate. Its rc PR targets release-candidate; merging it updates the package version there, but no Release workflow starts.
Recommended fix: Allow the release workflow to handle merged verwalter rc PRs against supported target branches, while retaining the bot and marker gates. Verify checkout and publish use the merged target commit.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "jose": "^5.1.2" | ||
| }, | ||
| "devDependencies": { | ||
| "@changesets/cli": "^3.0.0", |
There was a problem hiding this comment.
🟡 Package changeset scripts lose their executable
After @changesets/cli is removed, the server SDK's changeset and ci:publish scripts still invoke changeset. Both scripts fail after a fresh install instead of creating or publishing changesets.
Learn more
The server SDK retains two scripts that call the changeset executable: changeset and ci:publish. This deletion removes the package's direct CLI dependency, and the root manifest also drops it. Fresh installs therefore supply no changeset executable for those scripts.
Example: After pnpm install, pnpm --filter livekit-server-sdk changeset invokes the retained script and exits because changeset is missing.
Recommended fix: Replace or remove both obsolete scripts as part of the migration. Point the changeset-creation script to a supported verwalter command if maintainers still need it.
Was this helpful? React with 👍 or 👎 to provide feedback.
| continue-on-error: true | ||
| run: pnpm --filter=livekit-server-sdk build-docs | ||
| - name: S3 Upload Server SDK Docs | ||
| continue-on-error: true |
There was a problem hiding this comment.
🟡 Failed documentation uploads pass the release
When build-docs or the S3 upload fails, continue-on-error lets the release job pass. Operators see a successful release although the server SDK documentation remains outdated.
Learn more
The release publishes server SDK documentation after npm publishing. Both documentation steps now tolerate failure, unlike the previous release workflow. If the upload fails, GitHub reports the publish job successful despite the docs site remaining unchanged. If the build fails, the upload still runs with no fresh documentation.
Example: S3 rejects an upload due to expired AWS credentials. The step reports an error, but the workflow finishes successfully while the docs site stays on the previous SDK version.
Recommended fix: Remove continue-on-error from the documentation steps, or move documentation into a separately tracked job with explicit failure reporting. Run upload only when docs build succeeds.
Was this helpful? React with 👍 or 👎 to provide feedback.
Releases run through
changesets/actionin thebuild_and_releasejob ofci.yml. That job runs on every push tomain, and it both commits to the release PR and publishes. This PR moves the release to verwalter. Verwalter keeps one release PR that it regenerates frommain, and it tags before it publishes. Tag names, versions and changelogs continue without a gap.Change
verwalter.tomllistspackages/*(livekit-server-sdk,@livekit/rtc-node), the version inpackage.json, the existing tag format{package}@{version}, and npm as the registry. Private examples are left out.release-pr.ymlkeeps the release PR open on each push tomain.release.ymltags and creates the GitHub releases after the release PR merges. Then it builds both packages and runspnpm publishper package with npm trusted publishing. The server SDK docs build and S3 upload move to the end of this job.pre-release.ymlopens an rc PR on demand.changeset-check.ymlfails a PR that changes a package without a changeset. Theinternallabel skips the check.build_and_releasejob fromci.yml,.changeset/config.json, theci:publishscript, and@changesets/cliwith@livekit/changesets-changelog-githubfrom bothpackage.jsonfiles.ci.ymlnow needs onlycontents: read..changeset/*.mdfiles use the same format, so pending changesets carry over. EveryCHANGELOG.mdstays, and new entries go on top.Different afterwards
mainwith its own changeset.Releaseworkflow. It skips versions that npm already has.Verified
verwalter plan: 2 packages, 0 pending changesets.verwalter status: both packages at the version of their last tag, with the GitHub release published and the version on npm.verwalter pr --dry-run: nothing to release.pnpm install --frozen-lockfilepasses with the updated lock file.pinact run --checkpasses on the new workflows.For maintainers
The PR cannot do these:
VERWALTER_RELEASE_CLIENT_IDandVERWALTER_RELEASE_APP_KEYsecrets for the verwalter GitHub App. Withgithub.token, the release PR does not trigger CI.release.ymlexpects the authorverwalter-release[bot]. Without the App, change that check togithub-actions[bot].internallabel, and add it to this PR. The PR changes only devDependencies of a package.release.yml, notci.yml.Not done yet
[check].apiwith break-check). That is a follow-up.🤖 Generated with Claude Code