Skip to content

Experimental WARP - #4649

Open
cnderrauber wants to merge 6 commits into
masterfrom
warp
Open

Experimental WARP#4649
cnderrauber wants to merge 6 commits into
masterfrom
warp

Conversation

@cnderrauber

Copy link
Copy Markdown
Contributor

No description provided.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread pkg/telemetry/prometheus/packets.go

@boks1971 boks1971 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

How different are the pion forks? Would it be hard to keep syncing?

Also, the Devin suggestion looks good to apply.

@cnderrauber

Copy link
Copy Markdown
Contributor Author

lgtm!

How different are the pion forks? Would it be hard to keep syncing?

Also, the Devin suggestion looks good to apply.

The pion/webrtc,ice's changes are clean and not hard to apply when syncing. Pion/dtls has more lines, but the dtls1.2 is stable and the development is focus on dtls1.3 now, so we don't need to sync it frequently.

Comment thread go.mod Outdated

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread pkg/telemetry/prometheus/rooms.go

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 3 additional findings in Devin Review.

Open in Devin Review

Comment thread pkg/service/roommanager.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants