Add pagination support to egress list#851
Open
biglittlebigben wants to merge 6 commits into
Open
Conversation
milos-lk
reviewed
May 29, 2026
|
|
||
| resItems := res.Items | ||
| if remaining := limit - len(items); limit > 0 && len(resItems) > remaining { | ||
| resItems = resItems[:remaining] |
There was a problem hiding this comment.
just to double check since pages get older as we paginate, if the limit cuts mid-page - should we return its tail rather than the head?
There was a problem hiding this comment.
I forgot if we order asc or desc within a page - checking it
There was a problem hiding this comment.
ingress does newest last within a page - I guess that will apply to egress as well so this might be valid.
|
nit: The pagination tests cover the RPC control flow well — request count, page tokens, and when pagination stops. They don’t yet assert the user-visible behavior of --limit: which egress IDs are returned and in what order. (might be related to my other comment above) |
milos-lk
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.