Repository navigation
[CI copy] #396: Re-initialize FFIClient on entering Play mode without a domain reload - #398
Closed
MaxHeimbrock wants to merge 3 commits into
Closed
MaxHeimbrock wants to merge 3 commits into
MaxHeimbrock wants to merge 3 commits into
Conversation
The Editor raises Application.quitting when Play mode exits, so Quit() disposes the client and sets _isDisposed. Without a domain reload the flag stays set in the next Play session, every FFI event is dropped and Room.Connect times out waiting for ReadyForRoomEventRequest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rooms and streams from an earlier Play session stayed subscribed to the singleton and were kept alive once it was re-initialized without a domain reload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
#396 comes from a fork, so GitHub doesn't give its CI run the Unity license secrets and every Unity job fails. This draft PR runs CI on the same commits (head
2578cf5) from a branch in this repo. Don't merge it. Review and merge #396 instead.Changes
🤖 Generated with Claude Code