Skip to content

[CI copy] #396: Re-initialize FFIClient on entering Play mode without a domain reload - #398

Closed
MaxHeimbrock wants to merge 3 commits into
mainfrom
max/copy/pr-396
Closed

MaxHeimbrock wants to merge 3 commits into
mainfrom
max/copy/pr-396

Conversation

@MaxHeimbrock

Copy link
Copy Markdown
Contributor

Background

#396 comes from a fork, so GitHub doesn't give its CI run the Unity license secrets and every Unity job fails. This draft PR runs CI on the same commits (head 2578cf5) from a branch in this repo. Don't merge it. Review and merge #396 instead.

Changes

🤖 Generated with Claude Code

MirCore and others added 3 commits November 10, 2026 12:46
The Editor raises Application.quitting when Play mode exits, so Quit() disposes the client and sets _isDisposed. Without a domain reload the flag stays set in the next Play session, every FFI event is dropped and Room.Connect times out waiting for ReadyForRoomEventRequest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rooms and streams from an earlier Play session stayed subscribed to the singleton and were kept alive once it was re-initialized without a domain reload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants