Skip to content

Resolve flaky capture CI - #309

Merged
alan-george-lk merged 2 commits into
mainfrom
alan/bugfix-capture-ci
Nov 12, 2026
Merged

alan-george-lk merged 2 commits into
mainfrom
alan/bugfix-capture-ci

Conversation

@alan-george-lk

@alan-george-lk alan-george-lk commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Lots of CI failures due to issues pulling GStreamer from https://gstreamer.freedesktop.org/download/. This PR does the following:

  • Adds retries/error checking to relevant workflow steps
  • Caches GStreamer install for now (could remove if upstream is more reliable) to avoid CI issues

@alan-george-lk
alan-george-lk marked this pull request as ready for review November 12, 2026 18:18
@alan-george-lk alan-george-lk changed the title WIP: Resolve flaky capture CI Resolve flaky capture CI Nov 12, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

gst-inspect-1.0 --version

- name: Save GStreamer installers cache (macOS)
if: runner.os == 'macOS' && steps.gstreamer-cache-macos.outputs.cache-hit != 'true'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Corrupted installer caches never recover

When an exact cache hit contains a corrupt installer, download_pkg repairs the local copy but the save step skips it. The bad archive persists, forcing subsequent jobs to download from the flaky server again.

Learn more

The cache restore reports an exact hit before the installer hash is checked. If the restored bytes fail verification, download_pkg removes the local file and downloads a valid one. The save condition still sees the exact hit and cannot update the immutable GitHub Actions cache entry. The same condition affects the Windows save step and its Download-Installer function.

Example: A macOS cache entry contains a truncated runtime package but a valid development package. Every macOS job restores that entry, redownloads the runtime package, and skips saving the repaired pair. If freedesktop.org fails on the next job, capture setup fails despite a successful previous repair.

Recommended fix: Expose a verification or redownload outcome from each install step and save repaired installers under a new key when an exact-hit archive was corrupt. GitHub Actions caches are immutable, so merely running actions/cache/save again with the existing key cannot repair the entry. Apply the same recovery scheme to macOS and Windows.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems minimal risk, ignoring for now

expected_hash="$GSTREAMER_MACOS_RUNTIME_SHA256"
if [[ "$package" == "$devel_pkg" ]]; then
expected_hash="$GSTREAMER_MACOS_DEVEL_SHA256"
# freedesktop.org has been aborting large HTTP/2 transfers on GitHub

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if other services see this

@alan-george-lk
alan-george-lk merged commit 2440f75 into main Nov 12, 2026
50 checks passed
@alan-george-lk
alan-george-lk deleted the alan/bugfix-capture-ci branch November 12, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants