Repository navigation
Resolve flaky capture CI - #309
Conversation
| gst-inspect-1.0 --version | ||
|
|
||
| - name: Save GStreamer installers cache (macOS) | ||
| if: runner.os == 'macOS' && steps.gstreamer-cache-macos.outputs.cache-hit != 'true' |
There was a problem hiding this comment.
🟡 Corrupted installer caches never recover
When an exact cache hit contains a corrupt installer, download_pkg repairs the local copy but the save step skips it. The bad archive persists, forcing subsequent jobs to download from the flaky server again.
Learn more
The cache restore reports an exact hit before the installer hash is checked. If the restored bytes fail verification, download_pkg removes the local file and downloads a valid one. The save condition still sees the exact hit and cannot update the immutable GitHub Actions cache entry. The same condition affects the Windows save step and its Download-Installer function.
Example: A macOS cache entry contains a truncated runtime package but a valid development package. Every macOS job restores that entry, redownloads the runtime package, and skips saving the repaired pair. If freedesktop.org fails on the next job, capture setup fails despite a successful previous repair.
Recommended fix: Expose a verification or redownload outcome from each install step and save repaired installers under a new key when an exact-hit archive was corrupt. GitHub Actions caches are immutable, so merely running actions/cache/save again with the existing key cannot repair the entry. Apply the same recovery scheme to macOS and Windows.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Seems minimal risk, ignoring for now
| expected_hash="$GSTREAMER_MACOS_RUNTIME_SHA256" | ||
| if [[ "$package" == "$devel_pkg" ]]; then | ||
| expected_hash="$GSTREAMER_MACOS_DEVEL_SHA256" | ||
| # freedesktop.org has been aborting large HTTP/2 transfers on GitHub |
There was a problem hiding this comment.
i wonder if other services see this
Lots of CI failures due to issues pulling
GStreamerfrom https://gstreamer.freedesktop.org/download/. This PR does the following: