Skip to content

fix(ipc): treat closed inference process as dead in is_alive - #6673

Open
tulanisahil1-beep wants to merge 1 commit into
livekit:mainfrom
tulanisahil1-beep:fix/inference-health-check-closed-process
Open

fix(ipc): treat closed inference process as dead in is_alive#6673
tulanisahil1-beep wants to merge 1 commit into
livekit:mainfrom
tulanisahil1-beep:fix/inference-health-check-closed-process

Conversation

@tulanisahil1-beep

Copy link
Copy Markdown
Contributor

health_check was raising ValueError after _proc.close(), returning 500 instead of 503. Mirror the guard already used in _send_kill_signal (#4500).

Fixes #6672

@tulanisahil1-beep
tulanisahil1-beep requested a review from a team as a code owner August 3, 2026 07:06
@CLAassistant

CLAassistant commented Aug 3, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

health_check was raising ValueError after _proc.close(), returning 500
instead of 503. Mirror the guard already used in _send_kill_signal (livekit#4500).

Fixes livekit#6672
@tulanisahil1-beep
tulanisahil1-beep force-pushed the fix/inference-health-check-closed-process branch from 5d8afb3 to c62b14e Compare August 3, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

health_check raises ValueError: process object is closed after inference subprocess exits (missing same guard as _send_kill_signal, see #4500/#4694)

2 participants