docs(readme): fix syntax errors in StoryAgent and test snippets#5905
Merged
Conversation
- Add missing comma after instructions= in StoryAgent.__init__ super() call - Add missing 'with' in 'async AgentSession(...) as sess:' test snippet
davidzhao
approved these changes
May 30, 2026
theomonnom
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
instructions=f-string in theStoryAgent.__init__super().__init__(...)call — without it, Python raisesSyntaxErrorat the next keyword argument (llm=).async AgentSession(llm=llm) as sess:toasync with AgentSession(llm=llm) as sess:in the testing snippet — the previous form is not valid Python.Both snippets are copy-paste hazards: README fenced ```python blocks aren't executed in CI, so the errors went unnoticed.
Test plan
StoryAgentsnippet into a file and verify it parses withpython -c "import ast; ast.parse(open('f.py').read())".py_compileover fenced ```python blocks in README.md to prevent regressions.