fix(openai): delete trimmed empty audio items#5887
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
theomonnom
approved these changes
May 29, 2026
Contributor
Author
|
Good catch. I kept that helper for the update path below: when an existing item id is recreated with different content, it still avoids recreating server-only audio/image items whose content was never synced down. This PR only changes the remove path so those trimmed empty items can be deleted from the server context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_chat_ctx(), even if the local copy has empty contentFixes #5886.
To verify
uv run pytest tests/test_realtime/test_openai_realtime_model.py -quv run ruff check livekit-plugins\livekit-plugins-openai\livekit\plugins\openai\realtime\realtime_model.py tests\test_realtime\test_openai_realtime_model.pyuv run ruff format --check livekit-plugins\livekit-plugins-openai\livekit\plugins\openai\realtime\realtime_model.py tests\test_realtime\test_openai_realtime_model.pyuv run python -m py_compile livekit-plugins\livekit-plugins-openai\livekit\plugins\openai\realtime\realtime_model.py tests\test_realtime\test_openai_realtime_model.pygit diff --checkNotes
uv run python scripts\check_types.pycurrently fails on Windows inlivekit-agents\livekit\agents\cli\readchar.pybecause mypy sees POSIXtermios/ttyattributes as missing. The errors are outside this diff.