chore: remove unused SupervisedProc.launchJob base method - #2440
Open
detail-app[bot] wants to merge 1 commit into
Open
chore: remove unused SupervisedProc.launchJob base method#2440detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the base
SupervisedProc.launchJobmethod, which was fully superseded by the override inJobProcExecutorand never executed in production.Changes Made
launchJob(info: RunningJobInfo)method fromSupervisedProcinagents/src/ipc/supervised_proc.ts.Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Additional Notes
The base
launchJobwas dead since inception:JobProcExecutoroverrides it without callingsuper, andInferenceProcExecutor(which inherits it) never haslaunchJobinvoked — it implementsInferenceExecutor, notJobExecutor. The only call-site (proc_pool.ts:94) dispatches viaJobProcExecutor's override, never the base. Leaving it was also misleading since the base checksproc?.connectedwhile the real implementation checksinit.doneand sets#jobStatus.History
Dead Code PRs can be configured here.