Skip to content

chore: remove unused SupervisedProc.launchJob base method - #2440

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-supervisedproc-launchjob-base-f1d62d
Open

chore: remove unused SupervisedProc.launchJob base method#2440
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-supervisedproc-launchjob-base-f1d62d

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the base SupervisedProc.launchJob method, which was fully superseded by the override in JobProcExecutor and never executed in production.

Changes Made

  • Removed the launchJob(info: RunningJobInfo) method from SupervisedProc in agents/src/ipc/supervised_proc.ts.

Pre-Review Checklist

  • Build passes: All builds (lint, typecheck, tests) pass locally
  • AI-generated code reviewed: Removed unnecessary comments and ensured code quality
  • Changes explained: All changes are properly documented and justified above
  • Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included
  • Video demo: A small video demo showing changes works as expected and did not break any existing functionality using Agent Playground (if applicable)

Testing

  • Automated tests added/updated (if applicable)
  • All tests pass
  • Make sure both restaurant_agent.ts and realtime_agent.ts work properly (for major changes)

Additional Notes

The base launchJob was dead since inception: JobProcExecutor overrides it without calling super, and InferenceProcExecutor (which inherits it) never has launchJob invoked — it implements InferenceExecutor, not JobExecutor. The only call-site (proc_pool.ts:94) dispatches via JobProcExecutor's override, never the base. Leaving it was also misleading since the base checks proc?.connected while the real implementation checks init.done and sets #jobStatus.

History


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner September 8, 2026 06:00
@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cf2e6ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants