Skip to content

chore: remove dormant reconnectEvent infrastructure in inference STT #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove dormant reconnectEvent infrastructure in inference STT #2439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions agents/src/inference/stt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
SpeechEventType,
} from '../stt/index.js';
import { type APIConnectOptions, DEFAULT_API_CONNECT_OPTIONS } from '../types.js';
import { type AudioBuffer, Event, Task, cancelAndWait, shortuuid, waitForAbort } from '../utils.js';
import { type AudioBuffer, Task, cancelAndWait, shortuuid } from '../utils.js';
import { type VAD, VADEventType, type VADStream } from '../vad.js';
import { type TimedString, createTimedString } from '../voice/io.js';
import {
Expand Down Expand Up @@ -740,7 +740,6 @@ export class SpeechStream<TModel extends STTModels> extends BaseSpeechStream {
/** @internal */
_pendingExtra?: Record<string, unknown>;
private speechDuration = 0;
private reconnectEvent = new Event();
private stt: STT<TModel>;
private connOptions: APIConnectOptions;
private activeWs?: WebSocket;
Expand Down Expand Up @@ -1067,28 +1066,19 @@ export class SpeechStream<TModel extends STTModels> extends BaseSpeechStream {
const vadTask = activeVADStream
? Task.from(({ signal }) => processVAD(activeVADStream, ws!, signal), connController)
: undefined;
const waitReconnectTask = Task.from(
({ signal }) => ThrowsPromise.race([this.reconnectEvent.wait(), waitForAbort(signal)]),
connController,
);

try {
const taskResults = [sendTask.result, wsListenerTask.result, recvTask.result];
if (vadTask) taskResults.push(vadTask.result);

await ThrowsPromise.race([ThrowsPromise.all(taskResults), waitReconnectTask.result]);

// If reconnect didn't trigger, tasks finished - exit loop
if (!waitReconnectTask.done) break;

// Reconnect triggered - clear event and continue loop
this.reconnectEvent.clear();
await ThrowsPromise.all(taskResults);
break;
} finally {
connController.abort();
this.abortController.signal.removeEventListener('abort', onStreamAbort);
this.activeWs = undefined;
vadStream?.close();
const tasks = [sendTask, wsListenerTask, recvTask, waitReconnectTask];
const tasks = [sendTask, wsListenerTask, recvTask];
if (vadTask) tasks.push(vadTask);
await cancelAndWait(tasks, DEFAULT_CANCEL_TIMEOUT);
resourceCleanup();
Expand Down
Loading