-
Notifications
You must be signed in to change notification settings - Fork 362
fix: preserve adaptive interruption across tool calls #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
12829f9
fix: preserve adaptive interruption across tool calls
rosetta-livekit-bot[bot] 7b4b110
fix: preserve realtime speech boundaries
chenghao-mou 94f19d7
fix: avoid duplicate speech end on pause
chenghao-mou 471eb61
fix: restore interruption state after speech gaps
chenghao-mou 823251d
fix: retain user speech context on overlap resume
chenghao-mou c060966
fix: limit overlap resume fix to duplicate starts
chenghao-mou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/agents': patch | ||
| --- | ||
|
|
||
| Preserve adaptive interruption boundaries when agent playout pauses or enters a tool-call thinking gap. |
44 changes: 44 additions & 0 deletions
44
agents/src/inference/interruption/interruption_stream.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // SPDX-FileCopyrightText: 2026 LiveKit, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
| import type { InterruptionMetrics } from '../../metrics/base.js'; | ||
| import { MockWebSocket } from './_mock_ws.js'; | ||
| import { AdaptiveInterruptionDetector } from './interruption_detector.js'; | ||
| import { InterruptionStreamBase, InterruptionStreamSentinel } from './interruption_stream.js'; | ||
|
|
||
| vi.mock('ws', async () => { | ||
| const { MockWebSocket } = await import('./_mock_ws.js'); | ||
| return { default: MockWebSocket, WebSocket: MockWebSocket }; | ||
| }); | ||
|
|
||
| describe('InterruptionStreamBase metrics', () => { | ||
| it('does not count agent-ended overlap as a backchannel', async () => { | ||
| MockWebSocket.instances.length = 0; | ||
| const detector = new AdaptiveInterruptionDetector({ | ||
| apiKey: 'test-key', | ||
| apiSecret: 'test-secret', | ||
| baseUrl: 'http://localhost:9999', | ||
| }); | ||
| const stream = new InterruptionStreamBase(detector, {}); | ||
| const metrics: InterruptionMetrics[] = []; | ||
| detector.on('metrics_collected', (event) => metrics.push(event)); | ||
| const reader = stream.stream().getReader(); | ||
|
|
||
| try { | ||
| await vi.waitFor(() => expect(MockWebSocket.instances).toHaveLength(1)); | ||
| MockWebSocket.instances[0]!.simulateOpen(); | ||
| const event = reader.read(); | ||
| await stream.pushFrame(InterruptionStreamSentinel.agentSpeechStarted()); | ||
| await stream.pushFrame(InterruptionStreamSentinel.overlapSpeechStarted(0, Date.now())); | ||
| await stream.pushFrame(InterruptionStreamSentinel.overlapSpeechEnded(Date.now(), true)); | ||
| await event; | ||
|
|
||
| expect(metrics).toHaveLength(1); | ||
| expect(metrics[0]).toMatchObject({ numInterruptions: 0, numBackchannels: 0 }); | ||
| } finally { | ||
| await reader.cancel(); | ||
| await stream.close(); | ||
| } | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.