Track Simplification Pass Names#265
Merged
Merged
Conversation
rcosta358
added
enhancement
CatarinaGamboa
approved these changes
Jul 20, 2026
|
|
||
| public VCSimplificationResult(VCImplication implication) { | ||
| this(implication, null); | ||
| this.implication = Objects.requireNonNull(implication).clone(); |
Collaborator
There was a problem hiding this comment.
Do we use this "requireNonNull" in several places across the codebase? I was under the impression we didn't use that as a standard
Collaborator
Author
There was a problem hiding this comment.
Yes we don't, I'll remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes each
VCSimplificationResultsave the name of the simplification that produced it, which is derived automatically throughVCSimplificationPass.getName(). The VS Code extension can then display this information to make simplification results easier to understand.Example
Related Issue
None.
Type of change
Checklist
liquidjava-example/src/main/java/testSuite/(Correct*/Error*)mvn testpasses locally