screensaver-proxy: stop losing track of inhibitors - #465
Open
tangles-0 wants to merge 1 commit into
Open
Conversation
remove the watch for the client that actually vanished, and forget cookies once explicitly released. otherwise concurrent clients can steal each other's cleanup watches and leave the display awake. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
the csd-screensaver-proxy disconnect callback ends with:
g_hash_table_remove (manager->priv->watch_ht, sender);But sender is merely the last hash-table entry inspected.
I tracked this down because I got sick of the game i'm developing crashing and causing my monitor to stay awake forever. the Cinnamon lock screen is burned into my OLED :(
This PR:
UnInhibit, preventing a second cleanup attempt and the resulting invalid-cookie errorHow i fixed the bug and tested my fix
dbus-run-sessiontest script with 12 concurrent clients and verified every cookie was released when its owning connection disappearedUnInhibitis forwarded exactly once when that client later disconnects