Conversation
1. Five async render callback slots used `nullptr != task.page && !existPage(task.page)` as the guard, which short-circuits to false when task.page is null, falling through to dereference the null pointer 2. Change the operator from `&&` to `||` so the guard returns early when task.page is null OR the page has been destroyed, preventing null-pointer dereference 3. Affected functions: onDocPageNormalImageTaskFinished, onDocPageSliceImageTaskFinished, onDocPageBigImageTaskFinished, onDocPageWordTaskFinished, onDocPageAnnotationTaskFinished 4. Adapt _002 series unit tests: add existPage stub returning true and set non-null placeholder page pointer so stubbed handlers are still invoked Log: Fix null-page guard operator in PageRenderThread render callback slots Influence: Prevents crash when async render callback delivers to a null page
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @pengfeixx, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 3 days and 11 hours by commenting @sourcery-ai review. Upgrade to get a review now.
Reviewer's GuideFixes a null-pointer crash in asynchronous render callbacks by returning when the task page is null or no longer exists, and adapts the affected unit tests to exercise handler invocation with stubbed, non-null pages. Sequence diagram for safe asynchronous render callback handlingsequenceDiagram
participant Render as PageRenderThread
participant Sheet as DocSheet
participant Page as BrowserPage
Render->>Sheet: existSheet(task.sheet)
alt sheet exists
Render->>Page: existPage(task.page)
alt task.page is null or page does not exist
Render-->>Render: return
else page is valid
Render->>Page: handleRenderFinished(...)
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评分： 25/25 分 评价： 语法正确，逻辑清晰 潜在问题： 详细分析： 本次修改将5个异步渲染回调函数中的空指针守卫条件从 原始代码存在逻辑缺陷：当 task.page 为 nullptr 时， 修改后的代码使用 || 运算符，当 task.page 为 nullptr 时， 涉及的5个函数：
测试代码同步适配：新增 2. 代码质量 ✅评分： 25/25 分 评价： 代码结构清晰，注释完整 潜在问题： 详细分析： 修改范围精准，仅涉及必要的运算符替换和注释更新。注释从"页面已析构,丢弃残留回包"更新为"页面为空或已析构,丢弃残留回包"，准确反映了新的守卫逻辑。测试代码新增了 5处修改分别位于5个不同的回调函数中，属于相似但独立的守卫逻辑，不属于重复代码。无残留调试代码，无敏感信息泄露。 3. 代码性能 ✅评分： 20/20 分 评价： 性能良好，资源使用合理 潜在问题： 详细分析： 运算符从 && 改为 || 对性能无负面影响。短路求值仍然有效：当 task.page 为 nullptr 时， 4. 代码安全 🔒评分： 30/30 分 评价： 存在0个安全漏洞
漏洞对比统计： 新增漏洞 0 个，减少漏洞 0 个，持平 0 个 安全漏洞详情： 详细分析： 本次修改修复了潜在的空指针解引用漏洞（可导致程序崩溃/拒绝服务），属于安全增强。修改本身未引入任何新的安全漏洞。测试代码中使用的 📋 审查信息
本报告由 AI 代码审查工具自动生成 |
2 participants
fix(reader): correct null-page guard operator in render callback slots
nullptr != task.page && !existPage(task.page)as the guard, which short-circuits to false when task.page is null, falling through
to dereference the null pointer
&&to||so the guard returns early when task.page isnull OR the page has been destroyed, preventing null-pointer dereference
onDocPageBigImageTaskFinished, onDocPageWordTaskFinished, onDocPageAnnotationTaskFinished
placeholder page pointer so stubbed handlers are still invoked
Log: Fix null-page guard operator in PageRenderThread render callback slots
Influence: Prevents crash when async render callback delivers to a null page
Summary by Sourcery
Guard asynchronous render callbacks against null or destroyed pages before invoking page handlers.
Bug Fixes:
Tests: