pick from master

[add-uos]

pick from master

Summary by Sourcery

Harden asynchronous document rendering against object-lifetime races and unify dark-theme thumbnail rendering across sidebar views.

New Features:

• Apply consistent dark-theme rendering to thumbnails, bookmarks, notes, and search results while preserving photo regions and handling scanned pages.
• Cache thumbnail image-object bounds for use by sidebar night-mode rendering.

Bug Fixes:

• Prevent use-after-free during asynchronous rendering by decoupling worker tasks from document and page lifetimes, clearing stale tasks, and rejecting callbacks for destroyed objects.
• Avoid delayed pinch-gesture callbacks accessing destroyed browser instances.
• Clean orphaned tab-group records along with bookmarks.

Enhancements:

• Make rendering tasks use shared renderer ownership and value snapshots for safer worker-thread execution.
• Move document-opening process handoff back to the main thread and route task validation through document UUIDs.

Tests:

• Add coverage for renderer task cleanup, thumbnail image-bound propagation, safe document opening, and dark-theme rendering behavior across sidebar delegates.

[sourcery-ai]

Sorry @add-uos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 4 days and 6 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's Guide

The PR hardens asynchronous document rendering against sheet/page lifetime races by passing immutable task snapshots and shared renderer ownership, adds thumbnail image-region metadata for consistent NightFilter-based dark-mode rendering across sidebar views, cleans tab-group orphans, and updates comprehensive unit tests and stubs.

Sequence diagram for lifetime-safe asynchronous page rendering

sequenceDiagram
    participant BrowserPage
    participant PageRenderThread
    participant SheetRenderer
    participant MainThread

    BrowserPage->>PageRenderThread: appendTask(renderer, uuid, pageIndex)
    PageRenderThread->>SheetRenderer: getImage(pageIndex, ...)
    SheetRenderer-->>PageRenderThread: rendered image
    PageRenderThread-->>MainThread: sigDocPageNormalImageTaskFinished(task, pixmap)
    MainThread->>BrowserPage: existPage(task.page)
    alt page is alive
        MainThread->>BrowserPage: handleRenderFinished(pixmapId, pixmap)
    else page was destroyed
        MainThread-->>PageRenderThread: discard stale callback
    end

Loading

Sequence diagram for dark-mode thumbnail metadata flow

sequenceDiagram
    participant SideBarImageViewModel
    participant PageRenderThread
    participant SheetRenderer
    participant DocSheet
    participant ThumbnailDelegate
    participant NightFilter

    SideBarImageViewModel->>PageRenderThread: appendTask(renderer, uuid, index)
    PageRenderThread->>SheetRenderer: getImage(index, 174, 174)
    PageRenderThread->>SheetRenderer: getImageObjectRects(index, 174, 174)
    PageRenderThread-->>SideBarImageViewModel: handleRenderThumbnail(index, pixmap, imageRects)
    SideBarImageViewModel->>DocSheet: setThumbnail(index, pixmap, imageRects)
    ThumbnailDelegate->>DocSheet: data(IMAGE_NIGHT_MASK)
    ThumbnailDelegate->>NightFilter: applyPage(pixmap, imageRects)
    NightFilter-->>ThumbnailDelegate: dark-mode pixmap

Loading

Entity relationship diagram for document orphan cleanup

erDiagram
    DOCUMENT ||--o{ BOOKMARK : contains
    DOCUMENT ||--o{ TABGROUP : contains
    DOCUMENT {
        string filePath
    }
    BOOKMARK {
        string filePath
    }
    TABGROUP {
        string filePath
    }

Loading

File-Level Changes

Change	Details	Files
Reworked asynchronous rendering and document-opening tasks to avoid worker-thread access to destructible UI objects.	Capture shared renderer references and value snapshots (UUID, page index, file metadata, scale/size) when enqueueing tasks. Use UUID validation and shared renderer ownership in worker execution instead of dereferencing DocSheet or BrowserPage. Move QProcess ownership assignment back to the main-thread open callback. Add sheet/page task cleanup, page-lifetime tracking, and callback guards against stale responses. Update renderer ownership and APIs to use QSharedPointer and parentless SheetRenderer instances.	reader/browser/BrowserPage.cpp reader/browser/BrowserPage.h reader/browser/PageRenderThread.cpp reader/browser/PageRenderThread.h reader/browser/SheetBrowser.cpp reader/sidebar/SideBarImageViewModel.cpp reader/sidebar/SideBarImageViewModel.h reader/uiframe/DocSheet.cpp reader/uiframe/DocSheet.h reader/uiframe/SheetRenderer.cpp reader/uiframe/SheetRenderer.h
Added thumbnail image-object metadata propagation for intelligent dark-theme rendering.	Prefetch image-object bounding boxes during thumbnail rendering and carry them through the model into DocSheet thumbnail storage. Expose the metadata through a new IMAGE_NIGHT_MASK model role. Add cleanup behavior so replacing a thumbnail clears stale bounding boxes.	reader/browser/PageRenderThread.cpp reader/browser/PageRenderThread.h reader/sidebar/SideBarImageViewModel.cpp reader/sidebar/SideBarImageViewModel.h reader/uiframe/DocSheet.cpp reader/uiframe/DocSheet.h
Unified sidebar and search-result thumbnail dark-mode presentation through the NightFilter pipeline.	Replace delegate-local HSL inversion with NightFilter-based rendering that preserves image regions and handles scanned-page full inversion. Add scaled-coordinate handling, cached transformed pixmaps, and dark-theme border styling for notes. Make thumbnail display follow system theme rather than eye-protection mode.	reader/sidebar/BookMarkDelegate.cpp reader/sidebar/NotesDelegate.cpp reader/sidebar/NotesDelegate.h reader/sidebar/SearchResDelegate.cpp reader/sidebar/SearchResDelegate.h reader/sidebar/ThumbnailDelegate.cpp reader/sidebar/ThumbnailDelegate.h
Extended orphan cleanup to remove tab-group records along with bookmarks.	Delete tabgroup rows associated with orphaned file paths within the existing cleanup transaction.	reader/app/Database.cpp
Expanded and adapted unit coverage for task lifetime safety, thumbnail metadata, and dark-theme rendering.	Update stubs and API call sites for shared renderer/open-task changes. Add thumbnail image-rectangle propagation and worker prefetch tests. Add light/dark theme, image-mask, scanned-page, and eye-protection behavior tests for sidebar delegates.	tests/browser/ut_browserpage.cpp tests/browser/ut_pagerenderthread.cpp tests/browser/ut_sheetbrowser.cpp tests/sidebar/ut_bookmarkdelegate.cpp tests/sidebar/ut_notesdelegate.cpp tests/sidebar/ut_searchresdelegate.cpp tests/sidebar/ut_sidebarimageviewmodel.cpp tests/sidebar/ut_thumbnaildelegate.cpp tests/uiframe/ut_docsheet.cpp tests/uiframe/ut_sheetrenderer.cpp tests/ut_mainwindow.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[add-uos]

/forcemerge

[deepin-bot]

This pr force merged! (status: unstable)