Skip to content

chore: Update version to 6.0.66#680

Merged
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master
Jun 4, 2026
Merged

chore: Update version to 6.0.66#680
lzwind merged 1 commit into
linuxdeepin:masterfrom
add-uos:master

Conversation

@add-uos
Copy link
Copy Markdown
Contributor

@add-uos add-uos commented Jun 4, 2026

  • update version to 6.0.66

log: update version to 6.0.66

Summary by Sourcery

Chores:

  • Bump Debian changelog entry to version 6.0.66.

- update version to 6.0.66

log: update version to 6.0.66
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

TAG Bot

TAG: 6.0.66
EXISTED: no
DISTRIBUTION: unstable

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Jun 4, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Bumps the package version to 6.0.66 in the Debian changelog to reflect the new release.

File-Level Changes

Change Details Files
Update Debian package metadata to version 6.0.66.
  • Increment the version string in the latest Debian changelog entry to 6.0.66
  • Adjust any associated log or entry text to reference version 6.0.66
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

你好!我是CodeGeeX。我已经仔细审查了你提供的 Git Diff 内容。

本次提交是一个 Debian 变更日志的更新,记录了 deepin-devicemanager 版本升级到 6.0.66 的相关改动。由于本次 Diff 仅涉及 debian/changelog 文件,并不包含实际的 C++/Qt 代码改动,我将基于 Changelog 中提及的代码变更方向,为你提供相关的语法逻辑、代码质量、性能和安全方面的审查意见与改进建议。

1. 代码安全 - 命令注入防护

Changelog 记录: fix(security): use safe QProcess API to prevent command injection

  • 审查意见: 这是一个非常关键的安全修复。在 Qt 中,如果使用 QProcess::execute("command " + userInput) 或将未过滤的用户输入拼接到 shell 命令中,会导致严重的命令注入漏洞。
  • 改进建议:
    • 确保代码中已经移除了所有通过字符串拼接执行外部命令的逻辑。
    • 必须使用 QProcess::start() 的重载版本,即传递 QStringList 作为参数列表,而不是拼接后的完整字符串。例如:
    // 危险做法 (易受命令注入攻击)
    QProcess::execute("ls " + userDir); 
    
    // 安全做法 (参数分离,防止注入)
    QProcess process;
    process.start("ls", QStringList() << userDir);
    • 额外注意: 如果原逻辑依赖于 shell 的特性(如管道 |、重定向 >),使用 QProcess 参数分离可能会破坏原有逻辑。建议在 C++ 代码层面实现这些管道/重定向逻辑,或者如果必须使用 shell,一定要对输入进行严格的白名单校验和转义。

2. 语法逻辑 - 网络接口启停

Changelog 记录: fix: use NetworkManager D-Bus to enable/disable network interfaces

  • 审查意见: 弃用直接调用系统命令(如 ip link set dev eth0 up/downifconfig)而改用 NetworkManager (NM) 的 D-Bus 接口是极佳的做法,这符合 Linux 现代桌面应用规范。
  • 改进建议:
    • 异步逻辑: D-Bus 调用通常是异步的。请确保 UI 层在调用启停接口后,正确监听了 NM 的 D-Bus 信号(如 StateChanged),以更新界面上网卡的状态,避免界面卡死或状态不同步。
    • 权限校验: 操作 NM 启停网卡需要 PolicyKit 授权。请确保在调用 D-Bus 前,应用已正确配置了 .policy 文件,并在执行特权操作时请求了系统授权,否则 D-Bus 调用会被拒绝。
    • 错误处理: NM 可能会因为某些原因(如硬件开关关闭、依赖服务未启动)拒绝启停操作,务必捕获 D-Bus 的错误回复并给用户友好的提示。

3. 代码性能与逻辑 - CPU 信息展示

Changelog 记录: Fix(cpu): Improve CPU header fallback and dynamic PageMultiInfo header sizing / fix(cpu-header): use CPU(s) label for core count

  • 审查意见: 动态调整 UI 头部大小和回退逻辑如果处理不当,容易引起界面闪烁或布局重排的性能开销。
  • 改进建议:
    • 避免频繁布局: 在获取 CPU 信息或窗口 Resize 时,如果需要动态计算 Header 高度,建议使用 QTimer::singleShot(0, ...) 或在事件循环空闲时进行计算,避免在数据解析的循环中频繁触发 QWidget::updateGeometry() 导致性能下降。
    • 回退机制: CPU 核心数的获取应优先解析 /proc/cpuinfo 或使用 sysconf,如果失败再回退到外部工具(如 lscpu)。确保回退逻辑不会导致死循环或空指针异常。

4. 数据准确性 - MAC 地址获取

Changelog 记录: fix(network): prefer permanent MAC address from hwinfo

  • 审查意见: 优先获取永久 MAC 地址(烧录在网卡硬件中的地址)而不是随机化的 MAC 地址,这对于设备唯一性识别非常重要。
  • 改进建议:
    • 在 Linux 中,永久 MAC 地址通常可以通过 ethtool -P <iface> 或解析 sysfs (/sys/class/net/<iface>/address) 以及 hwinfo 获取。
    • 需要注意边界情况:某些虚拟网卡(如 Docker 桥接网卡、VPN 隧道网卡)可能没有永久 MAC 地址。代码逻辑中必须处理获取不到永久 MAC 的情况,并平滑回退到当前使用的 MAC 地址,避免程序崩溃。

5. 代码质量与测试 - Qt5 到 Qt6 迁移

Changelog 记录: test: migrate unit tests from Qt5 to Qt6 environment

  • 审查意见: 单元测试跟随主代码迁移到 Qt6 是保障软件质量的基石。
  • 改进建议:
    • Qt6 在容器类、字符串处理和隐式共享方面有较多 Breaking Changes。请确保测试用例覆盖了 QList/QVector 统一、QHash 随机种子变化等 Qt6 特性。
    • 建议在 CI 流水线中同时开启 Address Sanitizer (ASan) 和 Undefined Behavior Sanitizer (UBSan) 运行这些单元测试,以捕获 Qt6 迁移过程中可能引入的内存越界或未定义行为。

6. Changelog 格式规范

  • 审查意见: Changelog 中存在大小写不一致的问题。例如 fix(cpu-header)Fix(cpu)
  • 改进建议: 建议团队统一 Commit Message 和 Changelog 的规范(如遵循 Conventional Commits),全部使用小写(如 fix(cpu): ...),保持代码库和文档的整洁一致。

总结
本次 Changelog 反映的代码改动方向非常棒,特别是修复了命令注入安全漏洞和向 D-Bus 架构的迁移,大幅提升了应用的安全性和架构合理性。由于我无法看到具体的 C++ 代码,以上建议是基于这些变更点容易踩坑的地方给出的。如果你能提供具体的代码 Diff,我可以为你进行更深入的逐行代码审查!

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit c8c773d into linuxdeepin:master Jun 4, 2026
21 of 23 checks passed
@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot Bot commented Jun 4, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 6.0.66
  • Tag SHA: c15af8c36fe51b531920cacc0bac8de9ac213972
  • Commit SHA: c8c773d4e3f4f4fba260393eb4ac6ffd984fc41c
  • Tag Message:
    Release deepin-devicemanager 6.0.66
    
    
  • Tagger:
    • Name: add-uos
  • Distribution: unstable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants