Skip to content

fix(taskmanager): reject invalid drag in onEntered - #1682

Open
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0730/bug-370799
Open

fix(taskmanager): reject invalid drag in onEntered#1682
MyLeeJiEun wants to merge 1 commit into
linuxdeepin:masterfrom
MyLeeJiEun:fork-from-master-0730/bug-370799

Conversation

@MyLeeJiEun

@MyLeeJiEun MyLeeJiEun commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  1. Explicitly reject drag events when the dragged app cannot be docked
  2. Set drag.accepted to false before resetting dnd state for clarity

Log: Reject invalid app drag in dock taskmanager onEntered handler
Influence: Prevents dock from accepting undockable drags

fix(taskmanager): 在 onEntered 中拒绝无效拖拽

  1. 当拖拽的应用无法驻留时,显式拒绝拖拽事件
  2. 在重置拖拽状态前将 drag.accepted 置为 false

Log: 在任务栏任务管理器 onEntered 中拒绝无效的应用拖拽
PMS: BUG-370799
Influence: 防止任务栏接受不可驻留的拖拽

Summary by Sourcery

Bug Fixes:

  • Ensure drag events are explicitly rejected when the dragged app cannot be docked in the task manager.

1. Explicitly reject drag events when the dragged app cannot be docked
2. Set drag.accepted to false before resetting dnd state for clarity

Log: Reject invalid app drag in dock taskmanager onEntered handler
Influence: Prevents dock from accepting undockable drags

fix(taskmanager): 在 onEntered 中拒绝无效拖拽

1. 当拖拽的应用无法驻留时,显式拒绝拖拽事件
2. 在重置拖拽状态前将 drag.accepted 置为 false

Log: 在任务栏任务管理器 onEntered 中拒绝无效的应用拖拽
PMS: BUG-370799
Influence: 防止任务栏接受不可驻留的拖拽
@deepin-ci-robot

Copy link
Copy Markdown

Hi @MyLeeJiEun. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sourcery-ai

sourcery-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the dock taskmanager drag-and-drop handling so that undockable app drags are explicitly rejected in the onEntered handler and the drag state is clearly reset as not accepted before clearing DnD state.

Sequence diagram for dock taskmanager onEntered drag rejection

sequenceDiagram
    actor User
    participant DragSource
    participant TaskManager
    participant Applet

    User->>DragSource: start drag app
    DragSource-->>TaskManager: onEntered(drag)
    TaskManager->>Applet: requestDockByDesktopId(desktopId)
    alt [drag source is not taskbar] and [requestDockByDesktopId returns false]
        TaskManager->>TaskManager: drag.accepted = false
        TaskManager->>TaskManager: resetDndState()
    else [dockable]
        TaskManager->>TaskManager: proceed with normal DnD handling
    end
Loading

File-Level Changes

Change Details Files
Explicitly reject undockable app drags in the dock taskmanager onEntered handler and mark the drag as not accepted before resetting drag-and-drop state.
  • Add a conditional drag.accepted = false assignment when the dragged app cannot be docked and does not originate from the taskbar
  • Ensure drag.accepted is set to false immediately before calling the DnD state reset helper
panels/dock/taskmanager/package/TaskManager.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy, MyLeeJiEun

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants