fix(taskmanager): reject invalid drag in onEntered - #1682
Conversation
1. Explicitly reject drag events when the dragged app cannot be docked 2. Set drag.accepted to false before resetting dnd state for clarity Log: Reject invalid app drag in dock taskmanager onEntered handler Influence: Prevents dock from accepting undockable drags fix(taskmanager): 在 onEntered 中拒绝无效拖拽 1. 当拖拽的应用无法驻留时,显式拒绝拖拽事件 2. 在重置拖拽状态前将 drag.accepted 置为 false Log: 在任务栏任务管理器 onEntered 中拒绝无效的应用拖拽 PMS: BUG-370799 Influence: 防止任务栏接受不可驻留的拖拽
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the dock taskmanager drag-and-drop handling so that undockable app drags are explicitly rejected in the onEntered handler and the drag state is clearly reset as not accepted before clearing DnD state. Sequence diagram for dock taskmanager onEntered drag rejectionsequenceDiagram
actor User
participant DragSource
participant TaskManager
participant Applet
User->>DragSource: start drag app
DragSource-->>TaskManager: onEntered(drag)
TaskManager->>Applet: requestDockByDesktopId(desktopId)
alt [drag source is not taskbar] and [requestDockByDesktopId returns false]
TaskManager->>TaskManager: drag.accepted = false
TaskManager->>TaskManager: resetDndState()
else [dockable]
TaskManager->>TaskManager: proceed with normal DnD handling
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Log: Reject invalid app drag in dock taskmanager onEntered handler
Influence: Prevents dock from accepting undockable drags
fix(taskmanager): 在 onEntered 中拒绝无效拖拽
Log: 在任务栏任务管理器 onEntered 中拒绝无效的应用拖拽
PMS: BUG-370799
Influence: 防止任务栏接受不可驻留的拖拽
Summary by Sourcery
Bug Fixes: