refactor: move ShellSurfaceItemProxy to dock plugin level - #1681
Conversation
ShellSurfaceItemProxy has been relocated from the tray submodule to the dock plugin level to enable reuse across different dock submodules, including the cardleft plugin. The file is added to dock-plugin QML module and referenced via the org.deepin.ds.dock import. Log: ShellSurfaceItemProxy moved to dock plugin for cross-submodule sharing Influence: 1. Verify tray plugin ShellSurfaceItemProxy still works correctly 2. Test that the import path change doesn't break existing functionality 3. Verify quickpanel components load properly with new imports 4. Test cardleft plugin functionality after enabling it in CMakeLists 5. Verify no QML module resolution errors occur 6. Check SPDX license header updates are correct refactor: 将 ShellSurfaceItemProxy 移至 dock 插件层级 将 ShellSurfaceItemProxy 从 tray 子模块迁移至 dock 插件层级,使其可被 cardleft 等多个子模块复用。文件已添加到 dock-plugin QML 模块,并通过 org.deepin.ds.dock 导入引用。 Log: ShellSurfaceItemProxy 移至 dock 插件以实现跨子模块共享 Influence: 1. 验证 tray 插件的 ShellSurfaceItemProxy 功能正常 2. 测试导入路径变更后现有功能未受影响 3. 验证 quickpanel 组件加载新导入后正常 4. 测试在 CMakeLists 中启用 cardleft 插件后的功能 5. 确保无 QML 模块解析错误 6. 检查 SPDX 许可头部更新是否正确 PMS: TASK-392671
Reviewer's guide (collapsed on small PRs)Reviewer's GuideShellSurfaceItemProxy has been moved from the tray submodule into the shared dock-plugin QML module, with imports and CMakeLists updated so tray/quickpanel and other dock submodules can use it via org.deepin.ds.dock, and SPDX headers refreshed accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review★ 总体评分:95分■ 【总体评价】
■ 【详细分析】
■ 【改进建议代码示例】 diff --git a/panels/dock/CMakeLists.txt b/panels/dock/CMakeLists.txt
index 16d6aa5e0..7c084ec29 100644
--- a/panels/dock/CMakeLists.txt
+++ b/panels/dock/CMakeLists.txt
@@ -97,6 +97,5 @@ ds_install_package(PACKAGE org.deepin.ds.dock TARGET dockpanel)
ds_handle_package_translation(PACKAGE org.deepin.ds.dock)
# sub plugins
-#add_subdirectory(cardleft)
add_subdirectory(showdesktop)
add_subdirectory(taskmanager) |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ShellSurfaceItemProxy has been relocated from the tray submodule to the dock plugin level to enable reuse across different dock submodules, including the cardleft plugin. The file is added to dock-plugin QML module and referenced via the org.deepin.ds.dock import.
Log: ShellSurfaceItemProxy moved to dock plugin for cross-submodule sharing
Influence:
refactor: 将 ShellSurfaceItemProxy 移至 dock 插件层级
将 ShellSurfaceItemProxy 从 tray 子模块迁移至 dock 插件层级,使其可被 cardleft 等多个子模块复用。文件已添加到 dock-plugin QML 模块,并通过
org.deepin.ds.dock 导入引用。
Log: ShellSurfaceItemProxy 移至 dock 插件以实现跨子模块共享
Influence:
PMS: TASK-392671
Summary by Sourcery
Move the ShellSurfaceItemProxy QML component from the tray submodule into the shared dock plugin module and update tray quickpanel and delegate usages to import and reference it from org.deepin.ds.dock.
Enhancements:
Build: