initrd: replace all direct killall with release_scdaemon - #2170
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- oem-factory-reset.sh: add release_scdaemon after NK Storage AES key reset to release CCID lock (fixes regression from eb84f1b) - oem-factory-reset.sh: replace inline killall at top of main with release_scdaemon - seal-hotpkey.sh: replace inline killall with DO_WITH_DEBUG release_scdaemon - No direct killall to gpg-agent/scdaemon remains outside release_scdaemon body Signed-off-by: nestire <hannes@nitrokey.com> Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
force-pushed
the
fix-oemreset-nk-storage
branch
from
July 28, 2026 20:00
ae131de to
a887aae
Compare
Collaborator
Author
|
@nestire please review. LGTM |
nestire
reviewed
Jul 29, 2026
nestire
left a comment
nestire
left a comment
Contributor
There was a problem hiding this comment.
LGTM Test full OEM Factory Reset with v54 + Nitrokey Storage everything worked as expected, Thx
nestire
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2167.
to release CCID lock (fixes regression from eb84f1b)