refactor(error): per-transport TransportError and generic ceremony Error#297
Open
AlfioEmanueleFresta wants to merge 1 commit into
Open
refactor(error): per-transport TransportError and generic ceremony Error#297AlfioEmanueleFresta wants to merge 1 commit into
AlfioEmanueleFresta wants to merge 1 commit into
Conversation
5b0aea6 to
a4fd9a4
Compare
a4fd9a4 to
14afd71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today every transport failure collapses into one catch-all transport error, and the underlying cause from the OS, Bluetooth, USB, or tunnel layer is discarded. That makes diagnostics weak and leaves the error surface unsettled ahead of a 1.0 freeze.
This reworks the error model so the transport error type is known at compile time and the cause is preserved.
Changes
Channeltrait gains an associatedTransportErrortype. Each transport (HID, BLE, NFC, hybrid) has its own concrete error enum that carries the native cause instead of flattening it away.The ceremony error:
Closes #130.