fix(preflight): treat only no-credentials as credential absence#287
Merged
Merged
Conversation
Preflight mapped every getAssertion error to absence, so a transport timeout or any non-NoCredentials CTAP status silently dropped a credential from the filtered list. Only CTAP2_ERR_NO_CREDENTIALS proves a credential is absent, per the CTAP pre-flight procedure. Propagate all other errors to the caller so transient failures are not mistaken for absence.
AlfioEmanueleFresta
force-pushed
the
fix/preflight-no-credentials-only
branch
from
54fd71c to
983a601
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credential preflight treated every error as credential not present, so a transient transport error looked like a missing credential. It now treats only the explicit no-credentials response as absence and propagates other errors. This stops the client from silently skipping a credential that is actually present.