Repository navigation
TPT-2509: Use official golangci-lint GitHub Action - #247
Merged
zliang-akamai merged 2 commits intoSep 23, 2026
Merged
Conversation
zliang-akamai
added
the
repo-ci-improvement
zliang-akamai
requested review from
lgarber-akamai and
mawilk90
and
a lite review from Copilot
and removed request for
a team
August 29, 2026 03:46
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s linting workflow by moving PR CI linting from make check (which previously ran golangci-lint via Docker) to the official golangci/golangci-lint-action, while keeping local linting as a host CLI invocation.
Changes:
- Switch
make checkfromgolangci-lintin a Docker container to running the hostgolangci-lintbinary. - Replace the PR workflow’s
make checkstep withgolangci/golangci-lint-action.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Updates check to run golangci-lint directly on the host instead of via Docker. |
| .github/workflows/pull_request.yml | Replaces make check CI step with the official golangci-lint GitHub Action. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lgarber-akamai
approved these changes
Aug 31, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to lint execution wiring (Makefile + CI) and are consistent with the stated intent, with no additional issues found in the modified hunks.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
mawilk90
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Switch PR CI linting from
make check(Dockergolangci/golangci-lint) to the officialgolangci/golangci-lint-action. Keep localmake checkon the hostgolangci-lintCLI.✔️ How to Test
Confirm the
Pull Requestworkflow golangci-lint job succeeds on this PR.