Repository navigation
Add bounded client UI workflows with observed parent scopes - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add explicit client UI workflows to the persistent Skill session.
readonly-uisupports bounded observations and the installedcheckbox-auditrecipe;expand-uican observe, expand one proven parent when needed, and independently read a child checkbox. Successful findings require observed identity, uniqueness, state and the relevant evidence. Cancellation, unknown actions and incomplete results stop without automatic replay.Add
wincode_ui_set_expandedand observedscopePathselectors for inspect/review/setExpanded. The client carries the parent range through discovery, selection, expansion, continuation and final child readback. For example, two regions with identical advanced-group and checkbox IDs now return only the selected region's state, leaving the other region unchanged. Scoped requests require Host inspectionVersion 5; scoped actions verify capability before dispatch. A parent identical to the path's final selector reuses that root rather than querying a duplicate strict descendant.Keep existing single-tool JSON requests, readonly recipes and click/type behavior. Product/source and native components are aligned at 0.17.0. README, Skill, architecture and existing plans record the supported workflow, focus effects and M1–M6 merge line. The branch's historical model experiments are retained as limited evidence; benchmarks remain opt-in and do not run as a default application workflow.
Validation
npm run check: 493 tests, 492 passed, 0 failed, 1 existing optional fixed Tavern fixture skipped; typecheck, locked restore, Gateway/native publication, stdio and delivery checks passed.npm run check:desktop: 7 stages passed; 55/55 UI/source tests, no skips; actual desktop owner-death, native Tray and dual-client Tray workflow passed.Review and limits
Author self-review covers the entire increment from main, including client serialization/cancellation, scope validation and fresh resolution, old-Host action gating, audit/cleanup, and opt-in model execution. This is not an independent review. Required PR-head Node 22/24 and three CodeQL checks must pass before merging.
No recursive navigation, generated ancestor paths, scoped click/type, new services/dependencies, release assets or default-client reconnection. Non-WPF navigation, broad application/model coverage and stable performance remain outside the merge line. Expansion events may bring an application forward; functional validation does not establish a universal background guarantee. Raw window results and process identity reports remain in ignored local directories.