Add factory methods and extension methods for wrapping System.IDisposable objects#97
Open
konard wants to merge 3 commits into
Open
Add factory methods and extension methods for wrapping System.IDisposable objects#97konard wants to merge 3 commits into
konard wants to merge 3 commits into
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #23
konard
marked this pull request as ready for review
September 14, 2025 07:36
…able objects - Add Disposable.Create(IDisposable) static factory method - Add Disposable<T>.Create(IDisposable) static factory method - Add Disposable<TPrimary, TAuxiliary>.Create((IDisposable, IDisposable)) static factory method - Add AsDisposable() extension method for wrapping IDisposable in Disposable - Add AsDisposableContainer() extension method for wrapping IDisposable in Disposable<T> - Add comprehensive unit tests for all new functionality Fixes #23 - Think about implicit converters from other Disposables and IDisposable objects (to implement wrappers) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #23 by adding factory methods and extension methods that enable easy wrapping of System.IDisposable objects in the Platform's disposable wrappers.
Changes Made
1. Factory Methods
2. Extension Methods
3. Test Coverage
Usage Examples
Note on Implementation Approach
Initially attempted to use implicit operators, but C# doesn't allow user-defined conversions to or from interfaces (CS0552). The current implementation using factory methods and extension methods provides a clean, discoverable API while avoiding compiler limitations.
Fixes #23