Skip to content

Stream git log instead of buffering to fix ENOBUFS on large ranges #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomainCscn merged 1 commit into from
Jul 27, 2026
Merged

Stream git log instead of buffering to fix ENOBUFS on large ranges #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/base-sha.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,9 @@ describe("end-to-end: concurrent trains", () => {
if (repo) rmSync(repo.cwd, { recursive: true, force: true });
});

it("naive 'use first candidate' base scans commits already shipped via the main train", () => {
it("naive 'use first candidate' base scans commits already shipped via the main train", async () => {
const naiveBase = candidates[0]!.commitSha!;
const range = getCommitContextsBetweenShas(naiveBase, repo.mainHead, { cwd: repo.cwd });
const range = await getCommitContextsBetweenShas(naiveBase, repo.mainHead, { cwd: repo.cwd });
const messages = range.map((c) => c.message?.split("\n")[0]).filter(Boolean);

// m2 and m3 belong to 1.71.0; only m4 is the 1.72.0 bump. Using the
Expand All @@ -227,12 +227,12 @@ describe("end-to-end: concurrent trains", () => {
expect(messages).toEqual(["m4 (1.72.0 HEAD)", "m3 (1.71.0 release)", "m2"]);
});

it("findBaseSha picks the main release; range collapses to just the new bump", () => {
it("findBaseSha picks the main release; range collapses to just the new bump", async () => {
const result = findBaseSha(candidates, repo.mainHead, deps);
expect(result).toEqual({ kind: "found", sha: repo.mainPrev });
if (result.kind !== "found") return;

const range = getCommitContextsBetweenShas(result.sha, repo.mainHead, { cwd: repo.cwd });
const range = await getCommitContextsBetweenShas(result.sha, repo.mainHead, { cwd: repo.cwd });
const messages = range.map((c) => c.message?.split("\n")[0]).filter(Boolean);

expect(messages).toEqual(["m4 (1.72.0 HEAD)"]);
Expand Down
Loading
Loading