Skip to content

docs: sync CNY_ACCOUNT support with OpenAPI schema #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
claude wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

docs: sync CNY_ACCOUNT support with OpenAPI schema #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions components/grid-visualizer/src/data/account-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,4 +368,12 @@ export const accountTypeSpecs: Record<string, AccountTypeSpec> = {
],
beneficiaryRequired: true,
},
CNY_ACCOUNT: {
accountType: 'CNY_ACCOUNT',
fields: [
{ name: 'phoneNumber', example: '+8613812345678' },
{ name: 'bankName', example: 'Industrial and Commercial Bank of China' },
],
beneficiaryRequired: true,
},
};
10 changes: 10 additions & 0 deletions components/grid-visualizer/src/data/currencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,4 +265,14 @@ export const currencies: FiatCurrency[] = [
allRails: ['Bank Transfer', 'Mobile Money'],
examplePerson: { fullName: 'Carlos Morales', nationality: 'SV' },
},
{
code: 'CNY',
name: 'Chinese Yuan',
countryCode: 'cn',
accountType: 'CNY_ACCOUNT',
accountLabel: 'Chinese Bank Account',
instantRails: [],
allRails: ['Bank Transfer'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
Comment on lines +274 to +276
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The OpenAPI schema (CnyAccountInfo.yaml) restricts paymentRails to MOBILE_MONEY only, so labelling the rail as Bank Transfer here is inconsistent with the API contract. The label should reflect the actual underlying rail (mobile money via WeChat Pay / Alipay) to avoid confusing integrators.

Suggested change
instantRails: [],
allRails: ['Bank Transfer'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
instantRails: [],
allRails: ['Mobile Money'],
examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
Prompt To Fix With AI 
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/currencies.ts
Line: 274-276

Comment:
The OpenAPI schema (`CnyAccountInfo.yaml`) restricts `paymentRails` to `MOBILE_MONEY` only, so labelling the rail as `Bank Transfer` here is inconsistent with the API contract. The label should reflect the actual underlying rail (mobile money via WeChat Pay / Alipay) to avoid confusing integrators.

```suggestion
    instantRails: [],
    allRails: ['Mobile Money'],
    examplePerson: { fullName: 'Wei Zhang', nationality: 'CN' },
```

How can I resolve this? If you propose a fix, please make it concise.

},
];
4 changes: 2 additions & 2 deletions mintlify/snippets/country-support.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { FeatureCard, FeatureCardGrid, FeatureCardList, FeatureCardContainer } f
| 🇧🇷 Brazil | BR | `PIX` |
| 🇧🇬 Bulgaria | BG | `SEPA` `SEPA Instant` |
| 🇨🇲 Cameroon | CM | `Bank Transfer` |
| 🇨🇳 China | CN | `Bank Transfer` |
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Jun 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Payment rail label contradicts the OpenAPI schema

The OpenAPI schema for CnyAccountInfo (openapi/components/schemas/common/CnyAccountInfo.yaml) restricts paymentRails to a single enum value: MOBILE_MONEY. The account fields (phoneNumber + bankName) also match a phone-based mobile-money flow (consistent with WeChat Pay / Alipay), not a conventional direct bank transfer. Listing China here as Bank Transfer will mislead developers who then find the API only accepts MOBILE_MONEY as the payment rail. The same mismatch exists in currencies.ts (allRails: ['Bank Transfer']).

Prompt To Fix With AI 
This is a comment left during a code review.
Path: mintlify/snippets/country-support.mdx
Line: 27

Comment:
**Payment rail label contradicts the OpenAPI schema**

The OpenAPI schema for `CnyAccountInfo` (`openapi/components/schemas/common/CnyAccountInfo.yaml`) restricts `paymentRails` to a single enum value: `MOBILE_MONEY`. The account fields (`phoneNumber` + `bankName`) also match a phone-based mobile-money flow (consistent with WeChat Pay / Alipay), not a conventional direct bank transfer. Listing China here as `Bank Transfer` will mislead developers who then find the API only accepts `MOBILE_MONEY` as the payment rail. The same mismatch exists in `currencies.ts` (`allRails: ['Bank Transfer']`).

How can I resolve this? If you propose a fix, please make it concise.

| 🇨🇴 Colombia | CO | `Bank Transfer` |
| 🇭🇷 Croatia | HR | `SEPA` `SEPA Instant` |
| 🇨🇾 Cyprus | CY | `SEPA` `SEPA Instant` |
Expand Down Expand Up @@ -87,7 +88,7 @@ Regional Summary
<FeatureCard icon="/images/icons/globe.svg" title="Middle East and Africa" tag="14 countries">
Primary: Bank Transfer
</FeatureCard>
<FeatureCard icon="/images/icons/globe.svg" title="Asia-Pacific" tag="9 countries">
<FeatureCard icon="/images/icons/globe.svg" title="Asia-Pacific" tag="10 countries">
Various instant payment systems
</FeatureCard>
<FeatureCard icon="/images/icons/globe.svg" title="Americas" tag="5 countries">
Expand All @@ -102,6 +103,5 @@ Grid is rapidly expanding. These corridors are next on our roadmap — get in to
| Country | ISO Code |
|---|---|
| 🇨🇦 Canada | CA |
| 🇨🇳 China | CN |
| 🇭🇰 Hong Kong | HK |
| 🇰🇷 South Korea | KR |
Loading