Skip to content

loopdb: use pgx v5 for postgres#1152

Draft
hieblmi wants to merge 2 commits into
lightninglabs:masterfrom
hieblmi:upgrade-pgx-v5
Draft

loopdb: use pgx v5 for postgres#1152
hieblmi wants to merge 2 commits into
lightninglabs:masterfrom
hieblmi:upgrade-pgx-v5

Conversation

@hieblmi
Copy link
Copy Markdown
Collaborator

@hieblmi hieblmi commented Jun 5, 2026

• ## Summary

  • move Loop’s own Postgres store, migrations, and test fixture to the explicit pgx/v5 stdlib driver
  • switch Postgres error handling to the pgx/v5/pgconn types
  • bump lnd/kvdb and tidy module files so looprpc no longer pulls in pgx/v4

@hieblmi hieblmi self-assigned this Jun 5, 2026
@hieblmi hieblmi marked this pull request as draft June 5, 2026 09:33
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the database layer by migrating to the pgx/v5 driver for PostgreSQL. This change ensures better compatibility and performance, standardizes error handling across the application, and streamlines the dependency tree by removing outdated v4 references.

Highlights

  • Migration to pgx/v5: Transitioned Loop's Postgres store, migrations, and test fixtures to the explicit pgx/v5 standard library driver.
  • Error Handling Refactor: Updated Postgres error handling to utilize the modern pgx/v5/pgconn types.
  • Dependency Cleanup: Bumped lnd/kvdb and tidied module files to ensure looprpc no longer pulls in legacy pgx/v4 dependencies.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the database driver and migration framework from the legacy lib/pq and pgx/v4 to pgx/v5, along with updating Go and other dependencies. A critical issue was found in loopdb/postgres.go where the driver name is defined as "pgx/v5". Since the pgx/v5 stdlib driver registers itself as "pgx", using "pgx/v5" in sql.Open will cause a runtime panic.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread loopdb/postgres.go

const (
dsnTemplate = "postgres://%v:%v@%v:%d/%v?sslmode=%v"
pgxDriver = "pgx/v5"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The pgx/v5/stdlib driver registers itself under the name "pgx", not "pgx/v5". Using "pgx/v5" as the driver name in sql.Open will result in a runtime panic/error: sql: unknown driver "pgx/v5" (forgotten import?).\n\nPlease change the pgxDriver constant to "pgx" to ensure the driver can be correctly loaded.

Suggested change
pgxDriver = "pgx/v5"
pgxDriver = "pgx"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant