Skip to content

Lock Postgres stores on initialization #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benthecarman wants to merge 1 commit into
base: main
Choose a base branch
from
+186 −46
Open

Lock Postgres stores on initialization #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,14 @@ impl NodeBuilder {
/// The given `kv_table_name` will be used or default to
/// [`DEFAULT_KV_TABLE_NAME`](io::postgres_store::DEFAULT_KV_TABLE_NAME).
///
/// # Warning
///
/// Do not point multiple [`Node`] instances at the same database and table. Concurrent access is
/// unsafe and can corrupt node state. You must make sure that only one node accesses each
/// database and table. The store uses a PostgreSQL advisory lock to reduce this risk. This lock
/// is only a temporary safeguard and does not make concurrent access safe.
/// Nodes using a different database or table on the same server may coexist.
///
/// If `certificate_pem` is `Some`, TLS will be used for database connections and the
/// provided PEM-encoded CA certificate will be added to the system's default root
/// certificates (it does not replace them). If `certificate_pem` is `None`, connections
Expand Down Expand Up @@ -1230,6 +1238,14 @@ impl ArcedNodeBuilder {
/// The given `kv_table_name` will be used or default to
/// [`DEFAULT_KV_TABLE_NAME`](io::postgres_store::DEFAULT_KV_TABLE_NAME).
///
/// # Warning
///
/// Do not point multiple [`Node`] instances at the same database and table. Concurrent access is
/// unsafe and can corrupt node state. You must make sure that only one node accesses each
/// database and table. The store uses a PostgreSQL advisory lock to reduce this risk. This lock
/// is only a temporary safeguard and does not make concurrent access safe.
/// Nodes using a different database or table on the same server may coexist.
///
/// If `certificate_pem` is `Some`, TLS will be used for database connections and the
/// provided PEM-encoded CA certificate will be added to the system's default root
/// certificates (it does not replace them). If `certificate_pem` is `None`, connections
Expand Down
Loading
Loading