Fix SDF loadFont rejecting promise with target instead of error - #893
Merged
jfboeve merged 1 commit intoSep 14, 2026
Merged
Conversation
guilhermesimoes
commented
Sep 10, 2026
| }); | ||
|
|
||
| atlasTexture.on('failed', (error: Error) => { | ||
| atlasTexture.on('failed', (_target, error: Error) => { |
Contributor
Author
There was a problem hiding this comment.
Btw, this has been an issue in our migration from L2 to L3.
Given that in none of the listeners we ever use the first argument (target), would it be possible to change this:
renderer/src/common/EventEmitter.ts
Line 93 in 3015383
to simply
listeners[i]!(data); ?
In our app we have never needed access to the target.
Usually we do:
this.on(someEvent => {
// here we have access to `this`
});Or we do:
const child = this.child;
child.on(someEvent => {
// here we have access to `child`
});Don't see why we have to receive the target as the first argument.
Collaborator
There was a problem hiding this comment.
maybe we can implement this for v4.0 @wouterlucas? internally in the renderer I don't encounter use of target either?
loadFont rejecting promise with target instead of error
jfboeve
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.