Repository navigation
docs: close out 10 verified doc-correction issues (batch 4) - #1539
Draft
torimwhaley wants to merge 10 commits into
Draft
torimwhaley wants to merge 10 commits into
torimwhaley wants to merge 10 commits into
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Documentation validation✅ All blocking checks passed. Component system0 finding(s) across the corpus. Findings on lines this pull request touched are annotated inline in Files changed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 4 of the cloudy-needs-review burn-down. I checked every change against the lightdash codebase before editing, and each issue has its own commit.
SingleSeriesConfiguration.tsx/GroupedSeriesConfiguration.tsxandValueLabelPositionOptions.AiThreadsSettingsPage.tsx, andAiAgentAdminService.generateEmbedTokencallscheckOrganizationAdminAccess(manage:Organization).BigqueryWarehouseClientruns every query with the connection'slocation.datasetvalue inprofiles.yml, and picking a data set fills in Location. Verified:BigQueryForm.tsx.ExportResults/index.tsx→showToastWarning, anduseToaster.tsxsetsautoClose: 5000for warnings.useSettingsNavigation.ts(General → User impersonation) andSettings.tsx.app_uuidis reported by the data app in a request header and the server doesn't verify it, so it's best-effort attribution. Verified: comment onLightdashAppUuidHeaderinpackages/common/src/utils/api.ts.view:Learn(Organization Management group), linked from the Learn page. Built-in org roles have it. A custom org role needs it, and a project-level grant doesn't count. Verified:scopes.ts,roleToScopeMapping.ts,learnAccess.test.ts, andLearnLink.tsx.filtersprop replaces saved dashboard filters and re-matches tile targets by field name #1485: React SDK.filtersreplaces the saved dimension filters, but locked saved filters stay and SDK filters on locked fields are dropped. Each SDK filter is matched to tiles by field name and type, and per-tile targets from the Tiles tab aren't used. Verified:DashboardFiltersSync.tsx(SDK branch) andbuildSdkFilterTileTargets/matchFieldByTypeAndName.useSettingsNavigation.ts, route/generalSettings/customRoles).Left out
integrations/dbt/upgrading.mdx, and open PR docs: 35 small fixes from the issue backlog triage #1511 rewrites that note. I left it out to avoid conflicting.ai-agent-fast-decisionsrollout still waiting on a product call (Document the AI agents fast-response decision feature and its self-hosted environment variables #1345). Deferred.Noticed, not changed
workspace-admin/custom-roles.mdxsays Settings → General Settings → Custom Roles. In the app, Custom roles is its own entry under Organization settings. Open PR docs: 35 small fixes from the issue backlog triage #1511 already edits the Info callout on that page.Checks:
npm run validate:docs -- --changed-filesPASSED,npm run audit:components -- --baselinePASSED (baseline holds), andmint broken-links --check-anchors(4.2.917) found no broken links. The branch merges cleanly with every open PR (#1511, #1531, #1535, #1536, #1322).Linked Linear issues AE-1408, AE-1298, AE-1314, AE-1366, AE-1368, AE-1357, AE-1361, AE-1365, AE-1356, and AE-1382 are assigned to Tori. Their status is unchanged.
Commits are unsigned (made on a box that can't use 1Password SSH signing).