Repository navigation
docs: close out 6 verified doc-correction issues (batch 3) - #1522
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Documentation validation✅ All blocking checks passed. Component system0 finding(s) across the corpus. Findings on lines this pull request touched are annotated inline in Files changed. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 3 of the cloudy-needs-review burn-down. Every change was checked against the lightdash codebase before editing, and each issue has its own commit.
service-accountscommercial feature flag gates the settings entry (useSettingsContext.ts), and only self-hosted instances can set it, viaSERVICE_ACCOUNT_ENABLED(parseConfig.ts).AsyncQueryService, which is backend query execution.enqueueReviewClassifierEventis gated only by the org-levelisAiAgentReviewsEnabled, not by the user's permissions.acquireUnscopedcreates anew SshTunneland callsconnect()on every acquisition, and it skips the client cache whenuseSshTunnelis set.embeddingcommercial feature flag.chat:write.customizebacks the bot avatar. Verified:SLACK_FEATURE_SCOPES/getSlackFeatureAvailability(slackSettings.ts),getCustomIconArgs(SlackClient.ts), andSchedulerFormSlackError.tsx. Correction to the issue: availability is checked per feature now, so a missing scope only turns off the features that need it. Scheduled deliveries isn't disabled whenever any scope is missing. The new text follows the code.Left out
data-access.mdxanddata-apps.mdx), which closes both. Changing them here would conflict with that PR.mainby Scope disposable editing to non-concurrent workflows #1369 ("scope disposable editing to non-concurrent workflows"). The comparison table and the Disposable editing section say the later upload overwrites earlier changes. Upload does no version check (CoderService.upsertChart). The issue just wasn't closed, so it can be closed by hand.JEV_API_KEYalone doesn't turn it on.resolveAiDecisionClientalso needs the org-scopedai-agent-fast-decisionsfeature flag, which is described in code as a "master rollout switch". It's also off for Bedrock-routed orgs and agents pinned to a credential. Whether to document this rollout flag and the third-party JEV provider for self-hosters is a product decision, so I left it out.Noticed, not changed
reactions:write, even though the code lists it as the scope for writeback reactions (SLACK_FEATURE_SCOPES). It's worth a separate look.Checks:
npm run validate:docs -- --changed-filesPASSED,npm run audit:components -- --baselinePASSED (baseline holds),mint validate(4.2.917) passed,mint broken-links --check-anchorsclean.Linked Linear issues AE-1184, AE-1211, AE-1213, AE-1255, AE-1262, and AE-1270 are assigned to Tori. Their status is unchanged.
Commits are unsigned (made on a box that can't use 1Password SSH signing).