[WRONG BRANCH] release: carry the macOS keyring signing fix to main - #6273
Conversation
…ion (#6271) * fix(release): sign the packaged macOS keyring addons before notarization Notarization rejected the 2.73.0 preview app: Resources/keyring/*.node, bundled since #6161, were unsigned or ad-hoc and had no secure timestamp, and Tauri does not sign files under Resources. Sign each darwin addon in place with the Developer ID identity, hardened runtime and timestamp after the certificate import and before tauri build, verify the result, and fail a real release that lacks signing material. * fix(release): match keyring signature fields without a pipe (cherry picked from commit 11782ee)
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Summary
Carry #6271 (
11782eedc3, sign the packaged macOS keyring addons before notarization) ontomainso the 2.73.0 release can be retried.release.ymlruns from this branch, and the first 2.73.0 attempt was refused by Apple notarization becauseResources/keyring/*.nodewere unsigned (run 36648529039; nothing was published). The cherry-pick touches only.github/workflows/release.ymland its contract test; the version sources are unchanged.Release authorization: the repository owner explicitly authorized the 2.73.0 release on 2026-09-30; this main merge runs on that authorization, as the #6265/#6266 promotions did.
Verification
actionlintfindings unchanged.Checklist