Conversation
Constraint: Keep the existing once-only callback and empty/control-event exclusions in native and adapted Responses streams. Rejected: Match every event ending in .delta | control and echo payloads must not start output timing. Confidence: high Scope-risk: narrow Directive: First-output timing is a proxy observation, not the start of hidden reasoning or exact model decoding. Tested: 183 focused Bun tests; TypeScript typecheck; privacy scan; structure checks; documentation build; pre-fix regressions reproduce missing timing. Not-tested: Full repository suite; upstream live inference on this dev checkout.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
리뷰 · 우선순위 62 / 80이 PR은 Responses 스트림에서 “첫 출력” 시각을 찍을 때, 글자·추론만 보던 구멍을 고칩니다. 도구만 나오는 턴은 예전에 출력 토큰은 있는데 첫 출력 시각이 비었습니다. 네이티브 SSE는 비어 있지 않은
메인테이너의 판단이 필요한 지점 도구 인자의 공백 한 글자도 첫 출력으로 둘지, trim 후에만 칠지. draft·체크리스트·전체 스위트를 머지 전 필수로 둘지, 경계 테스트+호스트 CI만으로 충분한지. 너의 추천 동작 방향은 맞고, 다리·네이티브·문서가 한목소리입니다. 공백 규칙은 지금처럼 length>0으로 두고, tip of 이 댓글은 grok-bot이 작성했습니다 |
Summary
response.function_call_arguments.deltaandresponse.custom_tool_call_input.deltaevents in native Responses SSE, and nonemptytool_call_deltaarguments in the adapter bridge. Tool-only turns otherwise finish with output-token usage but no first-output timestamp.Verification
bun test tests/adapters/bridge.test.ts tests/server/response-log-inspection.test.ts tests/responses/sse-inspector-bounds.test.ts tests/server/management-api-logs-metrics.test.ts: 183 passed, 0 failed.bun run typecheck: passed.bun run privacy:scan: passed.bun run structure:check: passed.cd docs-site && bun install --frozen-lockfile && bun run build: passed; 545 pages built and 74,644 internal links checked.git diff --check: passed.bun run test:changed: started through the repository wrapper, resolved thedevcomparison commit, and launched Bun's import-connected changed test lane. Stopped after several minutes without a returned lane result on this Windows machine; not counted as passing. This broader result and the full repository suite remain outstanding before review readiness.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.