fix(security): harden management-auth admission and provenance by luvs01 · Pull Request #5363 · lidge-jun/opencodex

luvs01 · 2026-09-20T17:37:10Z

Summary

Harden management-auth admission and provenance in two places on the same subsystem.
ocx sync Aside refresh no longer POSTs the reusable admin token to a listener discovered only through spoofable /healthz liveness. The CLI now verifies the runtime record, challenges /healthz with an attestation nonce, verifies the proof, and authorizes the exact POST /api/client-integrations/aside/sync with a one-shot PID/port/method/path-bound HMAC capability (local-aside-sync-capability principal).
Remote Workspace mutations now require an operator-paired GUI session. ManagementSessionControl.isPaired re-evaluates session provenance (issuance === "pairing"), and both the namespace gate in handleRemoteWorkspaceRoutesOnDemand and route-level sessionOnly enforce it. Automatically bootstrapped loopback/Tailscale sessions remain read-only.

Verification

bun x tsc --noEmit - clean.
bun run structure:check - passed.
bun run privacy:scan - passed.
bun test tests/cli/cli-dispatch.test.ts tests/clients/remote-workspace-management.test.ts tests/server/server-management-auth.test.ts - 100 passed, 0 failed.
bun test tests/clients/aside-profile-sync-owner.test.ts tests/server/aside-profiles-routes.test.ts tests/server/server-auth.test.ts tests/server/local-provider-reload-client.test.ts - 155 passed; 3 failures observed: one was a real regression in the /healthz bounded-metadata key list, fixed in this PR; the other two are timing-sensitive Windows tests unrelated to this change (one passes in isolation; the "stalled 400 body timeout" case has a documented windows-latest contention note).

Checklist

Scope stays focused and avoids unrelated cleanup.
Docs or release notes were updated when needed.
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.

coderabbitai · 2026-09-20T17:37:15Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-20T17:37:23Z

⚠️ Deterministic hygiene checks failed.

unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: src/server/management-api.ts, src/server/management-auth.ts.

github-actions · 2026-09-20T17:37:36Z

⏳ DRAFT

hygiene: unsponsored_surface.

What to do

Fix unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: src/server/management-api.ts, src/server/management-auth.ts.

Review readiness checklist

✅ All CI tests are green on my local testing.
✅ I pushed my PR to the latest dev commit.
✅ I resolved all correct Codex and CodeRabbit findings.
✅ My PR is ready for review.

✅ 4/4 boxes ticked.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

lidge-jun · 2026-09-20T17:47:01Z

리뷰 · 우선순위 66 / 80

이 PR은 관리자 권한으로 바꾸는 일 두 가지를 더 좁힌다. 베이스는 dev다.

ocx sync가 Aside 프로필을 서버에 다시 맞출 때, 예전에는 /healthz가 살아 있다고만 보고 그 주소로 재사용 가능한 관리자 토큰을 보냈다. 그 응답은 가짜 프로세스가 흉내 낼 수 있다. 이제는 실행 기록의 PID·포트가 맞는지 보고, /healthz에 일회용 질문을 보내 증명 값을 확인한 뒤에만, 그 POST 한 번(POST /api/client-integrations/aside/sync)에만 쓰는 짧은 서명을 보낸다. 설정 파일에만 적힌 옛 프록시는 이 갱신을 하지 못한다. 프록시를 다시 켜야 한다. 주소를 직접 넘긴 경우(baseUrl)는 예전처럼 관리자 토큰을 쓴다. 실제 ocx sync 경로는 주소를 넘기지 않는다.

Remote Workspace에서 컴퓨터를 붙이거나, 세션을 켜거나, 프롬프트를 보내는 일은 운영자가 페어링으로 만든 대시보드 세션만 할 수 있다. 로컬이나 Tailscale로 자동 입장한 세션은 조회만 된다.

드래프트다. hygiene는 unsponsored_surface로 실패했다. src/server/management-auth.ts를 고쳤기 때문에, 메인테이너가 maintainer-sponsored를 달기 전에는 게이트가 통과하지 않는다. 준비 체크리스트 네 칸도 비어 있다.

src/server/management-auth.ts:459 hasLocalAsideSyncCapability - 새 서명을 서버가 받아 주는지, 같은 서명을 다시 내면 거절하는지, PID나 경로가 다르면 거절하는 테스트가 없다. 같은 방식인 provider reload에는 그 검사가 있다. 이번 테스트는 두 가지만 본다. CLI가 설정 포트만 있는 대상에게 요청을 보내지 않는 것, 그리고 세션 객체의 issuance를 손으로 tailscale-identity로 바꾸면 isPaired가 거짓이 되는 것이다.

src/server/management/aside-profile-routes.ts:308 POST /api/client-integrations/aside/sync - 이 라우트는 누가 들어왔는지 보지 않는다. 대시보드는 gui/src/pages/integrations/aside-profile-api.ts의 syncAsideProfiles에서 세션으로 같은 주소를 친다. provider reload처럼 이 서명만 허용하면 그 화면이 403이 된다. 서명으로 들어온 요청은 지금 구조에서도 처리될 수 있지만, 그 성공 경로를 잠그는 테스트는 없다.

작성자 검증에 Windows 타이밍 실패 2건이 남아 있다. 하나는 단독 실행에서 통과하고, stalled 400 body timeout은 windows-latest 경합이라고 적혀 있다. 이 PR이 만든 실패로 단정하긴 어렵다. 다만 로컬 155 passed만으로 스위트가 깨끗하다고 보면 안 된다.

메인테이너의 판단이 필요한 지점
인증 표면이라 maintainer-sponsored 없이 머지하면 안 된다. 대시보드 동기화는 세션으로 남겨 두고, CLI가 프록시를 찾아갈 때만 일회용 서명을 쓰는 지금 구조를 유지할지도 정해 달라. 서명만 허용으로 바꾸면 GUI POST가 막힌다.

너의 추천
의도는 맞다. 닫지 말고, 서명 수락·재전송 거절·잘못된 PID 거절 테스트를 넣은 다음 스폰서를 달고 드래프트를 풀어라. types.ts/config.ts 분리와 겹치는 중복 PR은 아니다.

이 댓글은 grok-bot이 작성했습니다

Aside sync: attest the running proxy via the runtime attestation secret and authorize the exact POST with a one-shot PID/port-bound HMAC capability instead of sending the reusable admin token to a listener found through spoofable /healthz liveness. Remote Workspace: require an operator-paired GUI session for mutations; automatically bootstrapped loopback/Tailscale sessions stay read-only.

luvs01 · 2026-09-21T16:48:33Z

The readiness checklist is complete and the branch is rebased on current dev. The remaining gate is unsponsored_surface — this PR touches a protected path and needs the maintainer-sponsored label to proceed. @lidge-jun could you review for sponsorship when convenient?

luvs01 · 2026-09-22T11:15:33Z

Consolidated into #5516 in native Stack #5518.

Source head: d3696900779b0107b65f4129f546b84738ece7ce. Replacement head: 92de8d4ab910474749d4f86efd0f4aa33c8131c9.

Superseded by #5516 at 92de8d4. All 1 unique non-merge contribution commit(s) from this PR head d369690 are carried with verified patch equivalence and cherry-pick provenance: d369690 -> b478da0. Subsequent code/test moves were checked and preserve the contribution. This closes a duplicate source in favor of the existing open stack; it does not claim the replacement has landed or passed release gates. Exact-head cross-platform checks and required independent review remain incomplete.

Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained.

@luvs01

) * fix(service): combine startup ownership, token binding, and slot retention Carries #5512 by @luvs01 (head a12b2ad), which consolidates #5477, #5306 and #5357: - bind the service API token to its owning state, canonicalize qualified-localhost binds, and carry WSL ownership state honestly (#5477); - take a fresh task listing for the second startup ownership decision (#5306); - retain workflow slots for streaming turns (#5357); - own server-auth fixture lifetime and project a current-schema config for it. Squashed from the PR's own diff (origin/dev...a12b2ad) onto current dev. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): self-heal a replaced package tree via drain-and-restart Carries #5513 by @luvs01 (head 4d168f1), which consolidates #5393 and its scheduler follow-up: detect a replaced installed package tree, degrade health honestly, and drive a timer-driven, retryable drain-and-restart whose verify step is deferred past scheduler re-entry. The guard factory lives in src/server/index/package-tree-guard.ts. Squashed from the PR's own diff (a12b2ad...4d168f1) onto the #5512 carry. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(security): combine install discovery, credential, and transport hardening Carries #5515 by @luvs01 (head 843f299), which consolidates #5359, #5285 and #5322: - keep selected Codex installation discovery off network filesystems, probe oversized wrappers through a held-handle prefix read, and stop a PATH scan at a refused probe (#5359); - exclude npm candidates inside the launch directory subtree (#5285); - refuse plaintext remote hub origins, fail closed on POSIX chmod for credential files, and skip the frame-log write when descriptor hardening fails (#5322). Squashed from the PR's own diff (origin/dev...843f299) onto the chain carry. Integration: structure/runtime.md wording reflowed by two lines so the combined service and security stacks stay within the 600-line structure budget. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(security): combine management-auth and boundary hardening Carries #5516 by @luvs01 (head 245d542), which consolidates #5326, #5312, #5363 and #5317: - harden pairing redemption, agent roster intake, and SOCKS5 decoding (#5326); - guard gh resolution, anchor the grok managed-region fences to whole lines, and bound provider-controlled text (#5312); - harden management-auth admission and provenance (#5363); - bound the /healthz version before it reaches diagnostics (#5317). Squashed from the PR's own diff (843f299...245d542) onto the #5515 carry. Integration: both stacks rewrote the shared server-auth test fixtures. The carry keeps the #5512 current-schema fixture projection and config helper (including its 4 KiB boundary case) and adds this PR's Aside sync capability assertions. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(security): combine adapter argv and upstream-body hardening Carries #5517 by @luvs01 (head 260a87b), which consolidates #5315 and #5336: - stage Qoder and CodeBuddy system prompts in private files instead of child-process argv, with exclusive creation and owned cleanup (#5315); - bound upstream error bodies and resolve account-scoped transports (Copilot, Devin) from the same OAuth snapshot as the bearer (#5336). Squashed from the PR's own diff (245d542...260a87b) onto the #5516 carry. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * feat(codebuddy): integrate capture-only tools with private prompt staging Carries #5582 by @luvs01 (head 3061ef9), which integrates the capture-only CodeBuddy tool bridge from #5148 by @mdwsk88 with the private prompt staging from #5517. Requests with a tool catalog advertise only the allowed tools through an isolated MCP server that captures calls without executing them; the client keeps approval, sandboxing and execution. Pre-init, undeclared, excessive or incomplete calls are rejected, streamed malformed tool arguments are suppressed, bridge staging failures return a fixed message, and an opt-in live acceptance harness is included. Design context: #5146. Squashed from the PR's own diff (260a87b...3061ef9) onto the #5517 carry. Co-authored-by: mdwsk88 <924038395@qq.com> * fix(client): bound total hub catalog response lifetime Carries #5252 by @luvs01 (head 779ef91): give the hub catalog body read an overall deadline (24x the inactivity window, capped at 120 s) on top of the inactivity window, and release refused, HTTP-error and 304 bodies without awaiting their cancellation. Squashed from the PR's own diff (origin/dev...779ef91). Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(grok): reserve model aliases only when the written config stays valid Reimplements #5281 by @luvs01. A user sub-table such as [model.ocx-mine.extra] only creates an implicit parent, so it no longer forces the generated table to a suffixed alias. The alias choice is now checked against the bytes actually written: the unsuffixed alias is used only when the final config (after model-reference rewriting) parses; otherwise the conservative choice that also reserves deeper headers is used, and a valid user file for which neither choice parses is refused without writing. Malformed user TOML keeps the previous conservative reservation. The original change reserved only exact two-segment headers, which could emit a duplicate [model.x] table when the user defines model.x through dotted keys. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codex-auth): scope Codex OAuth cancellation to the originating flow Reimplements #4923 by @luvs01 on the current login-state layout (in-flight controllers moved to src/oauth/login-flow-state.ts in #5220). Cancelling a Codex login was keyed only by provider, so a stale modal posting an old flowId could abort a newer attempt, and a cancel without a flowId expired every pending flow. - Each in-flight controller records the flowId that started it; a cancel whose flowId does not match the active attempt is refused before anything aborts. - POST /api/codex-auth/login/cancel requires a non-empty flowId, rejects unknown or non-pending flows with 400 without touching any row, and expires only that flow. Provider-wide cancellation through /api/oauth/login/cancel is unchanged. - ocx account cancel requires --flow for Codex providers and sends no request without it. The dashboard's 409 recovery keeps its code; its ownerless cancel is now refused, so it ends in the existing "already in progress" message instead of superseding a flow it does not own. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(socks5): bound compressed event streams by expansion, not total size Review follow-up to the #5516 carry. The 32 MiB decoded-body cap applied to every gzip/deflate response, so a long, normally compressed SSE stream through the SOCKS5 tunnel was cut once its cumulative output crossed the cap. Buffered responses keep the absolute cap; event streams may continue while decoded bytes stay within the greater of 32 MiB or 128x the coded bytes consumed, which still stops high-ratio bombs. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codex): keep scanning PATH past a missing Windows candidate Review follow-up to the #5515 carry. The held-handle reader reported a missing file or directory as open-refused, so the default existence probe stopped the PATH scan at the first absent PATHEXT candidate (for example codex.com) before it reached an installed codex.cmd. NtCreateFile's object-name-not-found and object-path-not-found statuses now map to a distinct not-found result that lets the scan continue; every other failure still refuses. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): require Windows ACL hardening before a frame-log append Review follow-up to the #5515 carry. On Windows the frame log ignored a failed permission change and appended anyway. Each append now hardens the target with the required Windows ACL helper and checks that the path still names the opened file before writing; any failure writes nothing. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(devin): bind catalog authority to the tenant destination Review follow-up to the #5517 carry. - The observe-only OAuth snapshot applied the Copilot-validated apiBaseUrl to every provider, so a crafted Devin credential could carry a Copilot host that the snapshot claimed as its own. The overlay now applies only to github-copilot. - Devin's live roster, stale fallback and cooldown were keyed by the token alone while discovery also depends on the validated tenant URL. The catalog authority and the matching routing-cache resolver now fingerprint the token together with the validated destination URL. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(codebuddy): fail closed on unverified bridge turns and staging collisions Review follow-up to the #5582 carry. - With the capture-only tool bridge armed, a successful terminal event is no longer accepted unless the CLI's system/init frame confirmed the bridge server; a turn that ends without it fails with tool_bridge_init_missing. - A tool_use block that arrives only in the complete assistant message, without the partial tool events the bridge captures, now fails the turn instead of being dropped silently; partial captures are deduplicated by id. - The catalog and MCP config staging files are created exclusively (wx, 0600), like the prompt file, so a pre-existing file fails before spawn. - The history-argument repair for a missing JSON object prefix is documented and tested as a provider-agnostic contract; other malformed strings keep {}. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> Co-authored-by: mdwsk88 <924038395@qq.com> * fix(service): keep service-command ownership bound to the recorded home Review follow-up to the #5512 carry. On WSL with CODEX_HOME unset, the carried allowance treated a legacy Linux ~/.codex install record as owned when discovery now selects the Windows profile, so service stop could stop the Linux-home service and then restore native Codex in the Windows home, and repair could rewrite the recorded home. Service commands again require the exact recorded home and name it in the refusal; the unattended startup inspector reaches the same foreign verdict. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): veto a package-tree restart when its server stops or loses ownership Review follow-up to the #5513 carry. - A package-tree restart accepted by the guard stayed scheduled after an explicit server.stop(), so the drain-and-respawn could reopen a server the caller had stopped. The caller that accepted a pending restart now receives a veto, and the guard uses it on dispose. - When running as a supervised service child, the automatic path checks service home ownership when accepting and again before the handoff; a mismatch keeps the 503 fence and skips the restart. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(security): resolve gh from fixed paths and look up pairing grants by digest Review follow-ups to the #5516 carry. - On Windows the automatically polled star-status route derived gh.exe roots from ProgramFiles and LOCALAPPDATA, so a process environment could select any absolute directory. Windows candidates are now the fixed system install paths, and the child PATH is only the resolved executable's directory. Other installs report gh as unavailable, which only hides the sidebar star state. - Pairing redemption looked each guess up by scanning every live grant; the map is keyed by the grant digest, so the lookup is now a direct get. A valid grant still redeems behind a throttled source. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test(server): cover the one-shot Aside sync capability end to end Review follow-up to the #5516 carry, which added a one-shot, HMAC-bound capability for the default ocx sync path without exercising it. A real listener now proves single use, refusal on replay, wrong path, query, method, pid or port, expiry and a bad MAC, and that the CLI default path performs the attestation and a bodyless POST (through a narrow transport seam). Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test: register the review follow-up test files in the layout maps Adds the three new test files from the L4 review follow-ups to both scripts/test-layout/layout.json and tests/fixtures/test-layout-expected.json. * test(grok): pin re-injection and strip for a nested user model table Review follow-up to the #5281 reimplementation: two injections are byte identical, every intermediate file parses, and strip restores the exact user content. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): harden a Windows frame log once per file identity Re-review follow-up: requiring Windows ACL hardening on every append spawned icacls for every relayed frame and could stall the realtime relay. The hardened file identity (device and inode) is now remembered for the log path; an unchanged file skips the respawn, and a replaced file at the same path is hardened again before any write. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(structure): describe the package-tree restart veto and ownership recheck Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): stop an automatic restart from handing off after an explicit shutdown Security review follow-up to the #5513 carry. Once an automatic package-tree restart entered its drain, an operator shutdown (signal or management stop) could still be followed by the restart handoff, because the drain cannot tell its own listener stop from an independent one. Explicit shutdown paths now mark the process, and an admission-bound restart checks that mark before every handoff step. Manually requested restarts keep their behavior. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(server): mark a management stop before its asynchronous teardown Security re-review follow-up: the management stop route marked the explicit shutdown only after awaiting the shared teardown, so an automatic restart draining concurrently could reach its handoff in that window. The mark now precedes the first await after the stop is accepted. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * test(server): allow post-lookup pruning in the pairing digest regression The digest-lookup regression trapped every iteration of the grant map, so a valid redemption failed once session minting pruned expired grants after the lookup (hosted CI test 4/4). The trap now fails only on a scan that precedes the digest lookup, which is the regression it guards. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix: repair standalone bridge and restart ownership Use the compiled CLI as the capture-only MCP entrypoint, release automatic restart fences on veto, align Devin discovery, and tighten Windows and local transport handling. Apply the documented Qoder prompt environment for both regions and update focused regressions and operator docs. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> Co-authored-by: mdwsk88 <924038395@qq.com> --------- Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> Co-authored-by: mdwsk88 <924038395@qq.com>

github-actions Bot added the intake: hygiene-blocked Deterministic PR hygiene checks failed label Sep 20, 2026

github-actions Bot added the bug Something isn't working label Sep 20, 2026

luvs01 force-pushed the fix/mgmt-auth-hardening branch from c76d35d to 169b865 Compare September 20, 2026 17:57

luvs01 force-pushed the fix/mgmt-auth-hardening branch from 169b865 to d369690 Compare September 21, 2026 13:49

lidge-jun mentioned this pull request Sep 22, 2026

fix(security): combine management-auth and boundary hardening #5516

Closed

7 tasks

luvs01 closed this Sep 22, 2026

lidge-jun mentioned this pull request Sep 22, 2026

fix(security): carry luvs01 service and security hardening stacks #5610

Merged

3 tasks

Navigation Menu

fix(security): harden management-auth admission and provenance - #5363

fix(security): harden management-auth admission and provenance#5363
luvs01 wants to merge 1 commit into
lidge-jun:devfrom
luvs01:fix/mgmt-auth-hardening

luvs01 commented Sep 20, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 20, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 •

edited

Loading

Uh oh!

lidge-jun commented Sep 20, 2026

Uh oh!

luvs01 commented Sep 21, 2026

Uh oh!

luvs01 commented Sep 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

luvs01 commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Checklist

Review readiness checklist

Uh oh!

coderabbitai Bot commented Sep 20, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 20, 2026

Uh oh!

github-actions Bot commented Sep 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ DRAFT

What to do

Review readiness checklist

Uh oh!

lidge-jun commented Sep 20, 2026

리뷰 · 우선순위 66 / 80

Uh oh!

luvs01 commented Sep 21, 2026

Uh oh!

luvs01 commented Sep 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

luvs01 commented Sep 20, 2026 •

edited

Loading

github-actions Bot commented Sep 20, 2026 •

edited

Loading