feat(gui): add guarded routed model picker drag ordering - #3887
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
af7b8af to
e6ddd95
Compare
리뷰 · 우선순위 52 / 80이 PR은 Web GUI Models 페이지에 라우티드(커스텀) 모델 순서 드래그를 넣습니다. 이슈 #3774의 “라우티드 슬라이스”입니다. 지금 주의: 이 슬라이스만으로는 #3774를 닫으면 안 됩니다. 본문도 native/featured 풀 피커 재배치는 열어 둔다고 명시합니다. 베이스는 gui/src/components/ModelPickerOrderEditor.tsx (신규) - gui/src/model-picker-order.ts / Models.tsx - 저장 계약이 기존 gui/tests/* - 테스트는 많이 있으나 실행 주장이 없습니다. 중앙 CI 슬롯을 기다리는 draft 상태와 맞습니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
7b6ecb3 to
94df96b
Compare
Add Custom routed ordering with fixed featured rows, keyboard controls, fresh settings snapshots and accepted-receipt recovery. Preserve native complete orders until an explicit preset/reset is accepted. Include source regressions and all nine locale strings; runtime checks await central CI. Implements the routed slice requested in #3774; native/featured full-picker placement remains open. Co-authored-by: leonclab <26379556+leonclab@users.noreply.github.com>
94df96b to
8ecf91f
Compare
…p ci] Keep cancellation and stale-response fencing while separating render state reconciliation from automatic transport startup. Preserve immediate user actions and cover unmount before automatic request issuance. Co-authored-by: leonclab <26379556+leonclab@users.noreply.github.com>
Keep stale and fresh GET resolvers distinct, assert cache integrity before revalidation, and persist successful mock PUT state separately per origin. Existing banner, deadline, duplicate-write and saved-order assertions stay. Co-authored-by: leonclab <26379556+leonclab@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Verification
3fb08ec9d5cb2bbee33995fc8f1d21f80f2c6707, based ondev@74089fdc3539677f5086ba05d7aea92a8c16e60d.lane=all, all 16 required per-chain jobs SUCCESS at this exact head. Prior run 34123021525 failed GUI lint and was cancelled; it is not passing evidence.dashboard-preview-3fb08ec9d5cb2bbee33995fc8f1d21f80f2c6707. Bothbuild-commit.txtand GUI tree832ddd9acb48dc79c7275f38f8506ae53f027188match the current source. Browser checks used local fixture APIs only: real drag, keyboard movement, save/reload, failed-save draft retention, native-order lock, and 390px Korean layout without horizontal overflow. No local build/install/suite was run.Korean mobile view (390x844)
Manual chain (
stack: null):All commits use
[skip ci]. Final required-head checks, policy gates and the actual screenshot are required before LANDABLE. Do not close #3774 for this slice.Checklist
Co-authored-by: leonclab 26379556+leonclab@users.noreply.github.com
Maintainer integration decision (MAINTAINERS.md, dev-only admin integration): @lidge-jun integrates #3887 (#3774 slice, carry with
Co-authored-by: leonclab) intodev. Exact-head evidence at3fb08ec9d: Cross-platform CI run 34124333662 — Linux test 1/4–4/4, macOS 1/2, 2/2, gates (GUI tests/lint/typecheck/build), storage policy, api usage, keyring ×3, npm-global ×3, docker smoke = success; Windows/macos control deferred to the final train head. Prospective merge tree oforigin/dev@74089fdc3+ head =139cade3f= tested tree. Screenshots from this run's dashboard-preview artifact. Independent source review PASS. Local suites NOT RUN. Maintainer integration, not self-approval.