fix(diagnostics): distinguish inbound body size evidence - #3819
Conversation
Record scoped roadmap and independent plan audit. Local suites are excluded by owner instruction; final remote CI will verify the combined candidate.
…ip ci] Report declared wire length, observed lower bounds, and decoded sizes without reading rejected payloads further or changing admission and retry policy. Follow up on #3573; thanks to @nowhere1975 for the content-free incident measurements. The issue remains open for exact compact-attempt evidence. Independent source review passed; final remote CI pending.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 60 / 80이 PR은 플랫폼 체인 2층입니다. 베이스는 #3818의 지금 네 가지 측정 카테고리를 씁니다. 문서 현재 경로 src/server/request-decompress.ts assertBodySizeWithinLimit(raw, …, observed_wire_lower_bound) - 스트리밍 리더가 이미 cap 아래에서 성공적으로 읽은 뒤의 이중 검사에도 lower_bound 라벨을 씁니다. 실제로 여기가 터진다면 보유 버퍼 길이는 exact wire에 가깝습니다. 보수적 라벨이라 치명적이진 않지만, 성공 경로 가드에는 decoded_exact/observed_wire_exact 쪽이 더 정직할 수 있습니다. 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Oversized request errors distinguish declared wire length, observed wire lower bounds, exact decoded buffers and decoder lower bounds. Fixed categories and numeric values travel through the existing HTTP 413 mapping without retaining rejected payloads or changing the 256 MiB cap and retry behavior.
Follow-up to #3573, with thanks to @nowhere1975 for the incident measurements. The issue remains open for the actual compact-attempt evidence. Layer 2, based on #3818.
Verification
6f2ad1ef32c113ff5827c58959c85cefa923b15c. Cross-platform CI, lane=all passed (26 successful jobs). The verification ref points to the same commit as the final PR.Checklist
Maintainer integration
The repository owner explicitly authorized admin integration of this manual chain into dev. The final combined head
6f2ad1ef32c113ff5827c58959c85cefa923b15cpassed all 26 CI jobs. One cancelled macOS shard was rerun with unchanged source, commands and limits; its original stall remains recorded rather than claimed fixed.Independent integration review found no conflict with current dev
a5f9c3497. A clean merge produced tree2c51d5e8042011fe8362e267b224016c6061d684; the relevant OAuth/body/container tests passed there on isolated Linux (129 passed, zero failures). This focused result is distinct from the full CI proof on the combined PR head. The branch commits preserve original contributors through Co-authored-by trailers.