Skip to content

fix(runtime): land conversation affinity and effective capabilities - #3716

Merged
lidge-jun merged 24 commits into
devfrom
codex/a-08-transition-watchdog
Sep 5, 2026
Merged

fix(runtime): land conversation affinity and effective capabilities#3716
lidge-jun merged 24 commits into
devfrom
codex/a-08-transition-watchdog

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • Exact head 5097e66faa031d4e11b09c8ad79ec94ecb3f713d: all 24 actual Linux, macOS and Windows CI producers passed in full cross-platform CI. Historical failed predecessor runs remain recorded; this is the tested integration candidate.
  • Remote pinned Bun1.4.0: focused transition tests4pass/0fail and typecheck passed. Controlled10.5s startup passes the new watchdog and fails the old10s guard; an injected startup exception is reported before the barrier. Quota-focused tests16pass/0fail and typecheck passed; delayed-queue and suppressed-delivery controls preserve the exact event assertions. Independent code, security and topology reviews passed.
  • No local tests, typechecks or builds were run, as requested by the owner. Final dev integration CI and docs-only closeout follow the verified merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Co-authored-by: SB Yoon 44089734+yansigit@users.noreply.github.com
Co-authored-by: Hako 25837994+devswha@users.noreply.github.com

t and others added 22 commits September 6, 2026 01:58
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 5, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 46 / 80

이 PR은 제품 타이밍이 아니라 Windows transition probe 테스트 하네스의 예산 결함만 고칩니다. 손대는 파일은 tests/codex-integration/codex-transition-state-race.test.ts 와 plan 노트뿐입니다. 지금 실패 로그(foundation run 33988432596)는 두 자식이 ready barrier를 올리기 전에 바깥 10초 데드라인에 걸렸고, 같은 픽스처는 스택 tip(33988434944)에선 통과했습니다. Windows 자식은 ready 전에 SID·known folder를 각각 최대 WINDOWS_PRINCIPAL_LOOKUP_TIMEOUT_MS (30초) PowerShell로 풀 수 있어, 10초 바깥 예산은 정상 동작도 거절할 수 있습니다.

고침은 세 가지입니다. (1) CHILD_TIMEOUT_MS 를 win32에서 2 * WINDOWS_PRINCIPAL_LOOKUP_TIMEOUT_MS + 5_000 으로 잡고 watchdogMs 로 감쌉니다. (2) waitForFiles 가 barrier 기다리다 자식이 먼저 죽으면 stderr와 함께 바로 실패합니다. (3) 테스트 finally에서 child.exited 를 await한 뒤 sandbox를 지워, 삭제 레이스를 줄입니다. 바깥 test timeout도 N * CHILD_TIMEOUT_MS 로 키웠습니다. winner/generation/shared-db/busy/unsafe-path 단언은 그대로입니다.

베이스는 dev가 아니라 codex/a-05-capabilities (#3694 capabilities 스택)입니다. A-lane은 이미 ancestry에 SSE, WS, recovery가 있고, 다음이 affinity/capabilities입니다. 이 테스트 후속은 그 tip 검증용이라, 지금 HEAD 6dd23d631 대비 단독 머지 가치는 낮고 스택 순서 의존이 큽니다. 우선순위 46은 실프로세스 레이스 픽스처를 살리는 유용한 chore지만 제품 경로가 아니고 스택이 깊기 때문입니다.

경로/심볼 - CHILD_TIMEOUT_MS - win32 identity 두 번 + 5초 headroom, 타 플랫폼 10초 + watchdogMs.
경로/심볼 - waitForFiles(paths, children) - 조기 exit 진단.
라인 - finally await Promise.all(children.map(c => c.exited)) - sandbox 삭제 전 회수.
경로 - 각 test timeout을 N * CHILD_TIMEOUT_MS 로 조정 - 단계 수에 비례.
경로 - src/codex/transition-state.ts 제품 코드 - 변경 없음.
경로 - 아래층 #3694 / affinity 스택 - 이 PR 단독 dev 랜딩 금지.

메인테이너의 판단이 필요한 지점

  • Windows CI에서 새 예산으로 delayed-ready 컨트롤이 구 10초에선 실패·신 예산에선 통과하는지 원격으로 확인했는지
  • A-lane 전체를 한 트레인으로 올릴 때 이 chore를 tip에 붙일지, capabilities 직후에 짧게 넣을지
  • 30초×2 예산이 CI wall-time에 과도한지, watchdog 배율만으로 충분한지

너의 추천
스택 대기. #3694(및 affinity 아래층)가 dev에 들어간 뒤 이 PR을 retarget하고 Windows exact-head 포커스 테스트로 검증한 다음 머지하세요. 제품 타임아웃을 건드리지 않은 점은 유지. types/config 분할 무관. 아래층이 방향을 바꾸면 close-don't-rebase.

이 댓글은 grok-bot이 작성했습니다

@lidge-jun
lidge-jun changed the base branch from codex/a-05-capabilities to dev September 5, 2026 21:45
@lidge-jun lidge-jun changed the title test(codex): budget transition probe startup from identity lookups fix(runtime): land conversation affinity and effective capabilities Sep 5, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review September 5, 2026 21:45
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 5, 2026 21:45
@lidge-jun

Copy link
Copy Markdown
Owner Author

Owner-authorized admin integration of the independently reviewed A stack through #3716.

Exact head: 5097e66. All 24 actual full cross-platform producers succeeded in https://github.com/lidge-jun/opencodex/actions/runs/33991642514. Any queued aggregation-only job is accepted only after directly checking its exact allowlist. No pending or failed functional producer of this integration candidate is waived.

Carries #3708 bounded Unix probe cleanup and deterministic verification, #3692 Command Code conversation affinity (source #3581), and #3694 effective provider capability evaluation (source #3671). Earlier failing foundation jobs remain recorded and are superseded by this fully tested descendant. All lower-layer and contributor commits remain ancestors; original author identities are preserved. After dev ancestry verification, originals and superseded review PRs are closed with the actual landing evidence. Related #3661 remains open.

Co-authored-by: SB Yoon 44089734+yansigit@users.noreply.github.com
Co-authored-by: Hako 25837994+devswha@users.noreply.github.com

@lidge-jun
lidge-jun merged commit a2f69c8 into dev Sep 5, 2026
45 of 61 checks passed
@lidge-jun
lidge-jun deleted the codex/a-08-transition-watchdog branch September 5, 2026 21:45
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T21:46:52.996684Z 5097e66 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot removed the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 5, 2026
@github-actions github-actions Bot added the bug Something isn't working label Sep 5, 2026
lidge-jun added a commit that referenced this pull request Sep 5, 2026
## Summary

- Archive the five completed A runtime/routing work units and record the disposition of original PRs #3672, #3679, #3568, #3581 and #3671. All five originals are closed and their credited changes are on dev.
- Record the actual final stack integration through #3716, dev merge `a2f69c8aa60976345740ae6f3d2301f89297328e`, including GitHub's automatic recognition of folded parents. Related #3661 remains open for the residual recovery scope.
- [Outcome and evidence](https://github.com/lidge-jun/opencodex/blob/5a9476e522c085b3e2308935d89401d07d5ae015/devlog/_fin/260906_a_runtime_stack/090_outcome.md).

## Verification

- Final candidate full CI [33991642514](https://github.com/lidge-jun/opencodex/actions/runs/33991642514): all 24 actual cross-platform producers and aggregate passed.
- Integrated dev CI [33993960826](https://github.com/lidge-jun/opencodex/actions/runs/33993960826): all 17 applicable producers and aggregate passed; two dispatch-only jobs correctly skipped.
- Diff against verified integration is confined to the five A documentation units. Runtime, tests and dependencies are byte-identical. Independent factual, attribution and privacy-content review passed; remote privacy scan passed at exact head `5a9476e522c085b3e2308935d89401d07d5ae015`.
- No local product tests, typechecks or builds were run, as requested by the owner.

## Checklist

- [x] Scope stays focused and avoids unrelated cleanup.
- [x] Docs or release notes were updated when needed.
- [x] Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants