fix(codex): report bounded main quota refresh outcomes - #3693
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 52 / 80이 PR은 main Codex quota refresh 결과를 Bounded outcome으로 투영해 CLI/account API에 붙입니다. 원본 quota 숫자만 보이면 운영자가 자동 refresh·hard-lock·수동 refresh 실패를 구분하기 어렵습니다. refresh outcome을 같은 스키마로 내보내면 CLI와 향후 GUI가 같은 말을 할 수 있습니다. 제품 라우팅·failover를 바꾸지 않는 관측 면이라 우선순위는 중간입니다. 아래 OAuth 401 층( 문서(
경로 경로 테스트 경로 원본 메인테이너의 판단이 필요한 지점
너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
Owner explicitly authorized admin merging the C-lane stack. Independent security/code review: PASS at |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
A successful main-account login can still show null quota without explaining whether the usage request failed. Return a bounded, optional
quotaRefreshdiagnostic for real main-account refresh attempts and expose it through the opt-in account CLI JSON path. Categories distinguish HTTP errors, missing quota, timeouts, network/response errors, and internal publication failures without serializing raw errors or credentials.Carries #3658 (source commit
035dfc2c77e3825e507442dff3f98a6631ee0e99) onto the current credential-generation and Reserve fencing. Diagnostic metadata is ephemeral, main-account only, and omitted for stale identity or cached/no-request paths. Existing admission, quota, cache and retry policy remain unchanged.Partially addresses #3644. This diagnostic slice does not resolve or close the underlying Windows/WHAM failure report.
Stack layer 5/5, depends on #3691 (
codex/c-lane-3576-d778). Review this layer only; merge bottom-up into dev.Verification
macmini-cfBun 1.4.0 atb2a0a22aa9582b554a296ddfcd2ee1ae0f2516c5: 554 pass / 0 fail across eleven focused files, source archive SHA256 verified.finally, and exercises a real stalled-child timeout/reaping case. Product client behavior and workflow timeouts are unchanged; the new head requires a fresh full CI pass.a22implementation and current dev integration preserves A’s core changes.Checklist
Co-authored-by: Ingwannu ingwannu@users.noreply.github.com