-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(claude): fall back to native launch when routing is off (carry of #3519) #3563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Scope the live-state fallback claim to the implemented path.
src/cli/claude.ts:597-656reads liveenabledonly for the local-proxy branch. Connected-client execution validates client and token state, then routes toclientState.value.serverUrlwithout reading the live field. Either add the live check to connected-client execution or identify this trigger as local-proxy-only in every locale.docs-site/src/content/docs/guides/claude-code.md#L83-L83: qualify the English table row.docs-site/src/content/docs/fr/guides/claude-code.md#L78-L78: qualify the French table row.docs-site/src/content/docs/ja/guides/claude-code.md#L39-L39: qualify the Japanese table row.docs-site/src/content/docs/zh-tw/guides/claude-code.md#L65-L65: qualify the Traditional Chinese table row.As per path instructions, public and translated documentation must remain synchronized with actual CLI behavior.
📍 Affects 4 files
docs-site/src/content/docs/guides/claude-code.md#L83-L83(this comment)docs-site/src/content/docs/fr/guides/claude-code.md#L78-L78docs-site/src/content/docs/ja/guides/claude-code.md#L39-L39docs-site/src/content/docs/zh-tw/guides/claude-code.md#L65-L65🤖 Prompt for AI Agents
Source: Path instructions