docs(devlog): close out the admin-token unit with the preload guard fix - #3514
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
Records PR #3507 (`663fdbb0a`) as the closure of carry-forward item 1 from the Windows baseline triage, and adds `031` explaining why that fix mattered independently of the failure count it removed. The count was the wrong headline. 161 red tests were the alarm; the damage was the handful that went green by doing something to the developer's machine, because the guard those suites rely on to refuse live elevation and Task Scheduler mutation had been skipped. A luckier run would have shown fewer failures and made the same writes. Also records what the plan audit changed — arm-then-lock became sandbox → arm → lock, because the first still leaves a worker able to read the real home — and the delivery-record rows for #3504 and #3507.
cb4b75f to
5ea7551
Compare
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ingwannu
left a comment
There was a problem hiding this comment.
The recorded outcome is useful and the commit references are correct, but the PR currently declares this unit closed while leaving every file under devlog/_plan/260905_admin_token_local_ux/. Current AGENTS.md defines _plan as open units and _fin as closed units moved after a terminal outcome; the security-notes section also says a shipped-fix write-up belongs in _fin. Please move the complete unit directory to devlog/_fin/260905_admin_token_local_ux/ in this PR and update any live references that must follow it. The two remaining Windows observations can stay explicit carry-forward items or become separate open units, but they should not make this closed admin-token unit advertise two contradictory states.
💡 Codex ReviewLine 28 in cb4b75f When lock acquisition throws—the Windows SID timeout this reorder explicitly targets—the _plan
This record says the work is merged, and the commit explicitly closes the unit, but all newly added records remain under AGENTS.md reference: AGENTS.md:L83-L86 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Closes out the
260905_admin_token_local_uxdevlog unit now that the Windows carry-forward it named has landed.Records PR #3507 (
663fdbb0a) against carry-forward item 1 of the baseline triage, and adds031for why that fix was worth doing independently of the 161 failures it removed:031also records what the plan audit changed. The original plan was arm-then-lock; the reviewer rejected it as incomplete, because arming before the lock while sandboxing after it still leaves a worker armed-but-unsandboxed — writes blocked, reads not. Shipped order is sandbox → arm + assert → lock.Delivery record gains rows for #3504 and #3507. Items 2 and 3 (the
multi-account auth storefailures, 22 of the surviving 25, and thekeep-native-v1argv assertion) stay open with their real counts rather than being quietly dropped.Verification
bun run privacy:scan— passed. Documentation only; nothing in the build, typecheck, or test path reads fromdevlog/. No pre-disclosure security material: every defect described is already public in a merged diff, which is theAGENTS.mdtest for what may live here.Checklist
dev