Skip to content

[WRONG BRANCH] chore(release): promote main v2.42.0 onto preview and open 2.43.0-preview - #3435

Merged
lidge-jun merged 24 commits into
previewfrom
codex/promote-preview-2430
Sep 4, 2026
Merged

[WRONG BRANCH] chore(release): promote main v2.42.0 onto preview and open 2.43.0-preview#3435
lidge-jun merged 24 commits into
previewfrom
codex/promote-preview-2430

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

Realign preview with main after the v2.42.0 release and open the next prerelease line.

preview had diverged from main: 28 commits on preview were absent from main, and 23 commits on main were absent from preview, so preview could not fast-forward (git push --dry-run rejects it as non-fast-forward, and the Protect preview ruleset blocks non-fast-forward updates). The divergence was history only — the sole content difference between the two branches was the package.json version line:

git diff origin/preview origin/main
-  "version": "2.42.0-preview.20260903"
+  "version": "2.42.0"

This merges main (48f818664, the v2.42.0 release commit) into preview and resolves the tree to main's content, so preview now matches the released tree exactly apart from its own prerelease version line.

Why the version moves. preview could not keep 2.42.0-preview.20260903: v2.42.0 has published, and the repository's own comparator ranks that prerelease behind its own stable release, which is exactly what tests/release-version-line.test.ts fails on.

compareReleaseTags("v2.42.0-preview.20260903", "v2.42.0")  = -1   # behind -> red
compareReleaseTags("v2.43.0-preview.20260904", "v2.42.0")  =  1   # ahead -> green
compareReleaseTags("v2.43.0-preview.20260904", "v2.43.0")  = -1   # correctly precedes the future stable

So preview opens the next prerelease line at 2.43.0-preview.20260904, consistent with dev moving to 2.43.0 in #3434.

Verification

  • git merge-base --is-ancestor origin/preview <head> — exit 0, so this is a fast-forward for preview and satisfies the non-fast-forward rule.
  • git merge-base --is-ancestor 48f818664 <head> — exit 0, confirming the v2.42.0 release commit is carried.
  • git diff --stat 48f818664 <head>package.json | 2 +-. The tree is otherwise byte-identical to the released main.
  • git merge-tree --write-tree origin/preview origin/main — clean, no conflicts.
  • Version ordering checked against compareReleaseTags from scripts/release-notes.ts (quoted above).
  • Full local suite intentionally not run; cross-platform CI is the authoritative verifier.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (Not needed: branch-alignment and version-line chore.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (No source change at all beyond one version string; the tree matches the already-released main.)

Note on enforce-target

enforce-target fails promotion PRs targeting preview by design, as recorded on the earlier promotion #3409. This PR supersedes #3409, which targeted the now-stale v2.42.0 line.

Summary by CodeRabbit

  • Chores
    • Updated the package version to 2.43.0-preview.20260904.

lidge-jun and others added 24 commits August 25, 2026 10:36
release: promote dev into main for v2.32.1
# Conflicts:
#	package.json
[WRONG BRANCH] merge dev into main for the v2.33.0 release
Promotes the dev integration line onto main. The resulting tree is byte-identical
to origin/dev, including package.json at 2.34.0.

The package.json conflict is resolved to dev's side, NOT to main's stale 2.33.0.
Earlier promotions (#2553, #2507) kept the target's version so the release bump
would land on its own "release: vX.Y.Z" commit. That is no longer legal: this very
delta adds tests/release-version-line.test.ts, which fails when the in-tree version
sits behind the highest release tag. With v2.34.0-preview.20260827 now published,
2.33.0 orders behind it, so a promotion carrying the stale line turns CI red on
every shard that runs the suite.

The consequence for the release step is that scripts/release.ts skips the bump
(release.ts:568, currentVersion === version), so v2.34.0 gets tagged on this merge
commit rather than on a separate release commit. The workflow creates the tag itself
after publishing and validates expected-sha against the checked-out commit, so the
tag still names exactly the audited tree.
[WRONG BRANCH] promote dev onto main for v2.34.0
[WRONG BRANCH] promote dev onto main for v2.35.0
[WRONG BRANCH] promote dev onto main for v2.36.0
[WRONG BRANCH] promote dev to main for the v2.37.0 release
[WRONG BRANCH] promote dev onto main for v2.38.0
[WRONG BRANCH] promote dev onto main for v2.39.0
release: promote dev to main for v2.40.0
…rkflow call (#3262)

Both v2.40.0 release dispatches (33615174183 preview, 33615177849 main) died
at startup_failure: a workflow_call cannot grant its callee more than the
calling job holds, and dev-version-bump.yml's job declares contents+pull-
requests write. #3129 wired the call but never dispatched a release, so this
is its first live run. The caller job now declares exactly the callee's two
permissions; no other job in release.yml gains anything.

Co-authored-by: jun <jun@lidge.dev>
(cherry picked from commit 7ce0ba5)
release: carry the release.yml permissions fix onto main for v2.40.0
[WRONG BRANCH] release: promote dev onto main for the main-account badge fix
…view

preview had diverged from main: it carried 28 merge commits main did not have,
while main carried 23 preview did not, so preview could not fast-forward.
The divergence was history only - the sole CONTENT difference between the two
branches was the package.json version line.

This merge takes main (48f8186, the v2.42.0 release commit) into preview and
resolves the tree to main's content, so preview now matches the released tree
exactly apart from its own prerelease version line.

The version could not stay at 2.42.0-preview.20260903: v2.42.0 has published,
and compareReleaseTags ranks that prerelease BEHIND its own stable release
(-1), which is what tests/release-version-line.test.ts fails on. preview opens
the next prerelease line at 2.43.0-preview.20260904, matching dev's 2.43.0.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner September 4, 2026 06:27
@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Sep 4, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T06:40:48.837482Z 3959e6d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title chore(release): promote main v2.42.0 onto preview and open 2.43.0-preview [WRONG BRANCH] chore(release): promote main v2.42.0 onto preview and open 2.43.0-preview Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • wrong target branch (preview); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft September 4, 2026 06:28
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d707cafd-9e81-4177-bc5b-4d7c71582fea

📥 Commits

Reviewing files that changed from the base of the PR and between bd85a6c and 3959e6d.

📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The pull request updates the package preview version in package.json from 2.42.0-preview.20260903 to 2.43.0-preview.20260904.

Changes

Package version update

Layer / File(s) Summary
Update package preview version
package.json
Line 3 updates the version field to 2.43.0-preview.20260904. No other declarations or files changed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3959e

This updates the preview package version to the next prerelease line. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the release change: it promotes main v2.42.0 to preview and opens the 2.43.0 preview line. This matches the stated PR objective and the package.json version update.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/promote-preview-2430

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

리뷰 · 우선순위 56 / 80

이 PR은 preview 브랜치를 mainv2.42.0 릴리스 트리에 다시 맞추고, 다음 프리릴리스 줄을 2.43.0-preview.20260904로 여는 릴리스 정렬 작업이다. 지금 로컬 dev HEAD는 072df52eb(package.json은 아직 2.42.0, 마지막 머지 #3423 메인 계정 카드 plan/ticket 배지 복구)이고, dev2.43.0으로 올리는 #3434는 아직 열려 있다. 즉 이 PR은 dev 제품 코드 경로를 바꾸는 게 아니라, 이미 나간 main 트리를 preview에 실어 프리릴리스 버전 줄만 한 칸 앞으로 미는 일이다.

본문 설명대로 previewmain은 히스토리만 갈라져 있었고(각각에만 있는 머지 커밋들), 실제 내용 차이는 package.json의 version 한 줄뿐이었다. Protect preview 규칙이 non-fast-forward를 막아서 preview를 그냥 앞으로 밀 수 없었고, 그래서 main(48f818664, v2.42.0 릴리스 커밋)을 preview 쪽으로 합친 뒤 트리는 main과 같게 두고 버전만 다음 줄로 바꾼다. 디프도 파일 하나가 전부다: package.json2.42.0-preview.202609032.43.0-preview.20260904.

버전을 그냥 2.42.0-preview…에 두면 안 되는 이유는 저장소 안의 tests/release-version-line.test.tsscripts/release-notes.tscompareReleaseTags 때문이다. 같은 숫자의 프리릴리스는 이미 나온 스테이블보다 로 정렬된다. 로컬에서 확인해 보면 v2.42.0-preview.20260903 vs v2.42.0 = -1(뒤처짐 → 테스트 빨강), v2.43.0-preview.20260904 vs v2.42.0 = 1(앞섬 → 초록), v2.43.0-preview.20260904 vs v2.43.0 = -1(미래 스테이블보다 앞서는 프리릴리스로 정상)이다. #3434dev2.43.0으로 올리는 것과 같은 다음 줄을 preview가 여는 셈이다.

체크 상태도 본문 노트와 맞다. hygiene·label·changes 등은 이미 통과했고, enforce-target만 실패한다. 예전에 #3409에서도 기록했듯, preview로 가는 프로모션 PR에서는 enforce-target설계상 실패하는 경우가 있다. 게이트/플랫폼 테스트는 아직 돌아가는 중이라, 머지 전에 초록만 확인하면 된다. 이 PR은 #3409(낡은 v2.42.0 줄 프로모션, 아직 OPEN)를 대체한다.

현재 dev 관점에서의 점수 56은 “제품 버그/기능은 아니지만 릴리스 기차가 막히면 다음 배포·프리뷰 정렬이 전부 밀리므로” 중상이다. types.ts/config.ts 스플릿이나 카탈로그 경로와는 무관하고, 닫을/리베이스할 기능 PR이 아니다.

package.json version - 2.42.0-preview.20260903 → 2.43.0-preview.20260904 한 줄 변경. 의도된 유일 콘텐츠 델타이며, 이 줄을 되돌리면 release-version-line 테스트가 다시 빨개진다.
경로/enforce-target - preview 대상 프로모션에서 실패가 예상된다(#3409와 동일). 실패 자체를 고치려 베이스를 dev로 바꾸면 이 PR의 의미가 사라진다.
경로/#3409 - 아직 OPEN인 이전 프로모션. 이 PR이 대체하므로 머지 후(또는 직전에) 닫아야 open PR 수가 부풀지 않는다.
경로/#3434 - dev의 2.43.0 범프와 같은 다음 줄을 연다. 둘이 어긋나면 preview는 2.43.0-preview인데 dev는 2.42.0인 상태가 잠깐 남는다(지금은 그 상태).
경로/WRONG BRANCH 제목 접두 - enforce-target/가드가 붙인 표식으로 보이며, 실제 base는 preview가 맞다. 제목만 보고 닫지 말 것.

메인테이너의 판단이 필요한 지점

  • enforce-target 빨강을 무시하고 preview 프로모션을 머지할지(이전 [WRONG BRANCH] chore(release): promote dev to preview for v2.42.0 #3409 관례 유지) 여부
  • #3409를 이 PR 머지와 함께 superseded로 닫을지, 지금 바로 닫을지
  • #3434(dev → 2.43.0)를 이 PR과 같은 타이밍에 머지해 버전 줄을 맞출지, preview만 먼저 열지
  • Protect preview / fast-forward 검증이 본문대로 통과했는지 머지 직전 한 번 더 눈으로 확인할지

너의 추천
게이트·플랫폼 CI가 초록이 되면(enforce-target 제외) 머지해서 preview를 v2.42.0 트리 + 2.43.0-preview.20260904로 맞춘다. 이어서 #3409는 superseded로 닫고, #3434도 같은 릴리스 턴에서 머지해 dev package.json을 2.43.0으로 올려 preview와 다음 줄을 맞춘다. 기능 코드 리뷰나 types/config 스플릿 대기는 필요 없다.

이 댓글은 grok-bot이 작성했습니다

@github-actions github-actions Bot added bug Something isn't working and removed chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). labels Sep 4, 2026
@lidge-jun
lidge-jun marked this pull request as ready for review September 4, 2026 06:38
@lidge-jun
lidge-jun merged commit 0748cf5 into preview Sep 4, 2026
30 of 33 checks passed
@lidge-jun
lidge-jun deleted the codex/promote-preview-2430 branch September 4, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant